Repository navigation
Conversation
rustbot
added
the
S-waiting-on-review
matthewhughes934
approved these changes
Oct 26, 2026
| shape, | ||
| ) | ||
| .max_width_error(shape.width, span), | ||
| token::LitKind::Bool |
Contributor
There was a problem hiding this comment.
I thought it be be clearer to have the comments next to the type like:
token::LitKind::Bool // token::LitKind::Bool is true or falseBut that would remove the comment: error[internal]: not formatted because a comment would be lost 🫠 I'll go check if there's an open issue for that
Contributor
Author
There was a problem hiding this comment.
Yeah, that's why I didn't place them there.
Contributor
Author
There was a problem hiding this comment.
@matthewhughes934 there was an initial attempt at solving this at #6893, but we haven't merged it yet because it contains some other changes that I wanted removed. I don't think we necessarily need to worry about that right now, but I'm bringing it up because there are several linked issues on that PR.
Based on rustfmt issue 7215 it seems that we missed handling different kinds of string literals. Before trying to address that issue I thought it would be best if we refactored the match to be exhaustive.
ytmimi
force-pushed
the
refactor_rewrite_literal
branch
from
October 27, 2026 03:07
14ce102 to
afea4a8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #7215 it seems that we missed handling different kinds of string literals. Before trying to address that issue I thought it would be best if we refactored the match to be exhaustive.