Skip to content

Fix has_local to not search PATH for external 'local' command #5018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
harriiinnii wants to merge 2 commits into from
Closed

Fix has_local to not search PATH for external 'local' command #5018

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73ac8e1
fix: prevent has_local from finding external 'local' command via PATH
harriiinnii Aug 17, 2026
9495d64
fix: restore executable mode and suppress SC1007 in has_local
harriiinnii Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rustup-init.sh
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
# mksh has this alias by default.
has_local() {
# shellcheck disable=SC2034 # deliberately unused
local _has_local
PATH= local _has_local

@rami3l rami3l Aug 20, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe try (PATH= local _has_local)?

View changes since the review

}

has_local 2>/dev/null || alias local=typeset
Expand Down
Loading