Add initial support for packer #242
Conversation
|
Was able to confirm that the image built with packer is able to successfully run the builder when launched as a fresh instance. |
There was a problem hiding this comment.
Thanks for bootstrapping Packer, @rylev! <3
I think this is a good first step and we can merge it pretty much as-is. In the long-term, I'd like to try to get rid of the apply script and its custom logic to handle the environments. Which seems even more benefitial now that Packer requires these hacks as well. Not sure if we can drop the script yet, though...
| @@ -8,7 +8,7 @@ | |||
| - name: install apt packages | |||
| apt: | |||
| name: | |||
| - aptitude # needed by ansible itself | |||
| # - aptitude # needed by ansible itself | |||
There was a problem hiding this comment.
This seems like an unrelated change. Was this necessary to build the AMI?
| Before running the packer script, you will need to initialize packer: | ||
|
|
||
| ```bash | ||
| packer init ./docs-rs-builder |
There was a problem hiding this comment.
This needs to be run from within the packer directory, correct? If so, do you want to add a cd packer or so to the snippet?
| data "amazon-parameterstore" "revision" { | ||
| name = "/docs-rs/builder/sha" | ||
| region = "us-east-1" | ||
| } |
There was a problem hiding this comment.
The formatting is broken here. We run terraform fmt in CI, do we want to do the same for Packer?
| BASE_PATH = pathlib.Path(__file__).resolve().parent | ||
| VENV_PATH = BASE_PATH / ".venv" | ||
|
|
||
| # Ansible changes a lot between releases and deprecates a lot of stuff each of |
There was a problem hiding this comment.
| # Ansible changes a lot between releases and deprecates a lot of stuff each of | |
| # Ansible changes a lot between releases and deprecates a lot of stuff in each of |
This adds initial support for running packer with our Ansible setup.
Since the way we handle Ansible configuration is slightly unorthodox (i.e., we have the apply script which allows us to handle multiple environments more easily), we have created a wrapper for packer that sets up the Ansible environment properly. Running this wrapper looks like this:
The script works by creating a python virtual environment and copying the proper Ansible configuration into a directory (much in the same way that the
applyscript does - in fact, I modified theapplyscript to create the ansible "workspace" through a reuseable function that the new wrapper script uses). It then runspacker buildwith the correct template.As a downside, this does require the packer configuration files to be aware of this special environment they're running in and target the correct path for the playbook and inventory file. While I wish this could be more straight forward, this is probably the price we have to pay for supporting multiple environments and running both plain Ansible as well as packer.