Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope down promote_release IAM role S3 permissions #279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Scope down promote_release IAM role S3 permissions #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion terraform/releases/impl/promote-release.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,17 @@ resource "aws_iam_role_policy" "promote_release" {
"${aws_s3_bucket.static.arn}/doc/*",
"${aws_s3_bucket.static.arn}/dist",
"${aws_s3_bucket.static.arn}/dist/*",

]
},
{
Sid = "BucketsReadDelete"
Effect = "Allow"
Action = [
"s3:GetObjectAcl",
"s3:GetObject",
"s3:DeleteObject",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I actually am not sure we need delete permissions on the CI artifacts bucket -- I think we should only read from that bucket. Are you aware of some deletion in our scripts?

]
Resource = [
// Artifacts bucket
"${data.aws_s3_bucket.artifacts.arn}/rustc-builds",
"${data.aws_s3_bucket.artifacts.arn}/rustc-builds/*",
Expand Down