Upkeep for Playground deployment #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shepmaster
force-pushed
the
playground-upkeep
branch
from
00f6633 to
d906b99
Compare
shepmaster
force-pushed
the
playground-upkeep
branch
from
d906b99 to
f653e7f
Compare
meysam81
reviewed
Sep 21, 2023
| proxied: | ||
| - domain: "{{ vars_playground_domain }}" | ||
| to: "http://localhost:{{ vars_playground_env_ui_port }}" | ||
| to: "http://127.0.0.1:{{ vars_playground_env_ui_port }}" |
There was a problem hiding this comment.
Is this any different, I wonder? 🤔
There was a problem hiding this comment.
Check out the commit message
| @@ -25,3 +25,8 @@ | |||
| src: after-ssl-renew.sh | |||
| dest: /etc/ssl/letsencrypt/after-renew.d | |||
| mode: 0750 | |||
|
|
|||
| - name: create systemd override file | |||
| template: | |||
There was a problem hiding this comment.
Ansible-lint suggests writing the FQDN name of the task: ansible.builtin.template.
It's probably worth considering enforcing ansible-lint on the CI to have a consistent style everywhere.
| @@ -0,0 +1,2 @@ | |||
| [Service] | |||
| LimitNOFILE={{ (worker_connections * 2) + 32 }} | |||
There was a problem hiding this comment.
Quick question: what's the equation for? This multiplication and addition.
shepmaster
force-pushed
the
playground-upkeep
branch
from
f653e7f to
15dc1ac
Compare
shepmaster
force-pushed
the
playground-upkeep
branch
from
15dc1ac to
786c69f
Compare
jdno
approved these changes
Mar 12, 2024
The playground server only listens on an IPv4 address, not IPv6. Sending requests to `localhost` routes to both the IPv4 **and** IPv6, which results in a percentage of requests seemingly randomly failing.
With the WebSocket functionality, we now have a number of latent connections hanging out.
This allows us to influence the OOM killer's behavior, hopefully killing our processes instead of something more important to the system.
The default driver can be inefficient [1] as it reads / parses / formats / writes a large JSON file over and over. Since all of the playground's communication goes over stdin / stdout, that can be a lot of junk logged! The `local` driver should be more efficient. [1]: docker/for-linux#641
This is expected to happen when the service restarts while a container is running, as we don't have a graceful cleanup in the service. It can also happen unexpectedly during a crash. For some reason, this also happens when the service hasn't restarted (naturally or unexpectedly) and I haven't had a chance to hunt that down yet.
shepmaster
force-pushed
the
playground-upkeep
branch
from
786c69f to
ce8b5e4
Compare
|
Rebased now that #393 is merged and I added the last commit (the container GC script) |
MarcoIeni
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes have been running in production for a while after I hand-applied them. The Ansible-specific changes are mostly to see that the managed changes match close enough to the manual changes, but hopefully will be helpful to others.