Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add second docs.rs build process to metrics collection #352

Merged

Conversation

syphar
Copy link
Member

@syphar syphar commented Oct 4, 2023

after we got a bigger EC2 machine for docs.rs, we are setting up a second build-process to parallize builds.

This gives us a bigger advantage than just having faster non-parallel builds.

I don't know anything about the network topoligy between prometheus & the docs.rs server, so the change here is an untested guess.

The second build-server exposes a small HTTP server at the port where it returns the prometheus metrics.

If this doesn't work we could also configure a special path in the nginx config that proxies the request to the second build process.

@Mark-Simulacrum
Copy link
Member

I checked the security group on the current docs.rs instance and it doesn't allow port 3001 through, so I think we will want to re-expose that through nginx.

(Already mentioned on Zulip but re-iterating here for a track record: https://rust-lang.zulipchat.com/#narrow/stream/356853-t-docs-rs/topic/second.20build.20process.20on.20server/near/396664285)

@syphar syphar force-pushed the docrs-second-builder-metrics branch from 98f7a8f to cd0d51b Compare October 14, 2023 17:56
@syphar
Copy link
Member Author

syphar commented Oct 14, 2023

@Mark-Simulacrum I updated the NGINX config & this PR

@Mark-Simulacrum Mark-Simulacrum merged commit 7ea59f4 into rust-lang:master Oct 14, 2023
3 checks passed
@syphar syphar deleted the docrs-second-builder-metrics branch October 15, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants