Remove unused cache behavior #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom cache behavior for `/assets` was never used, since the pattern matches only the specific `/assets` URL and not any resources served under it (e.g. `/assets/foo`). This was discovered while investigating the inconsistencies in rust-lang#356. Since the configuration was never used in the first place, we are removing it to remove some complexity.
Turbo87
approved these changes
Oct 23, 2023
Mark-Simulacrum
approved these changes
Oct 23, 2023
|
@Mark-Simulacrum agreed, though it is apparently still using some sort of legacy caching configuration for CloudFront. we thought it was probably better to recreate it using their (new?) recommended caching policy system instead, and potentially wait for crates.io to serve assets directly from S3 instead of Heroku. simplifying the config here for now will likely make the migration easier :) |
jdno
added a commit
to jdno/rust-simpleinfra
that referenced
this pull request
Oct 23, 2023
Two recent changes to the CloudFront configuration (rust-lang#356 and rust-lang#357) for crates.io have been merged and deployed to both staging and production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom cache behavior for
/assetswas never used, since the pattern matches only the specific/assetsURL and not any resources served under it (e.g./assets/foo). This was discovered while investigating the inconsistencies in #356.Since the configuration was never used in the first place, we are removing it to remove some complexity.
cc @Turbo87