Initial SQS queue + user policy #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdno
requested changes
Jan 8, 2024
|
This looks like a good starting point. 👍 Can I help you with Terragrunt somehow? |
Co-authored-by: Jan David <[email protected]>
|
Hm, I'm not sure there's a good intermediate step, I can probably copy what I did for bors with some adjustments for the deployed-ref business... |
|
I'm also happy for you to just take this and run with it. |
jdno
approved these changes
Jan 8, 2024
|
I'm gonna merge this and continue in a separate branch so that we review new changes more easily. |
jdno
added a commit
to jdno/rust-simpleinfra
that referenced
this pull request
Jan 9, 2024
The SQS queue that was configured in rust-lang#377 has been deployed to the new staging account for crates.io that was created in rust-lang#374. Slight modifications were necessary to the configuration: - The resource and human-readable names of the SQS are now identical. - The `sid` for policies matches the naming rules of AWS. - The input variable has been changed, since the account number is not part of a bucket's ARN and can thus not be extracted from it. The infrastructure has been deployed with the same version of the Terraform provider for AWS as the other modules in simpleinfra to ensure future compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new terragrunt module for the new crates.io account(s) and puts the SQS queue and related IAM policies into the module. However, it does not yet wire up the account or try to deploy this -- I haven't connected those bits yet and getting terragrunt to cooperate with me is usually pretty finicky. Hopefully this helps as a starting point though.
Remaining steps:
Possibly:
IMO if we can, let's deploy this before we actually finish wiring up s3 -- crates.io can start reading from the queue and such early that way and kick the tires.
cc #372
r? @jdno cc @Turbo87