Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs.rs: allow POST requests #444

Merged
merged 1 commit into from
Jul 17, 2024
Merged

docs.rs: allow POST requests #444

merged 1 commit into from
Jul 17, 2024

Conversation

syphar
Copy link
Member

@syphar syphar commented Jul 17, 2024 •
edited
Loading

For rust-lang/docs.rs#2534 we need to allow POST requests.

( I'm not 100% sure if this change is enough? I looked at the crates.io web-app policy )

@syphar
Copy link
Member Author

syphar commented Jul 17, 2024

r? @jdno

fyi @pflanze

@jdno jdno merged commit 942c651 into rust-lang:master Jul 17, 2024
3 checks passed
@syphar syphar deleted the allow-post-requests-for-docs-rs branch July 17, 2024 13:58
@syphar
Copy link
Member Author

syphar commented Jul 17, 2024

@jdno could you ping me when this is deployed?

( for the case that is is already, I might have to search what other settings are missing, since I'm still getting the same error )

@jdno
Copy link
Member

jdno commented Jul 17, 2024

@syphar I am deploying this and #354 right now. Hit a small issue, though:

The parameter AllowedMethods is invalid (must be: [HEAD, GET] or [HEAD, GET, OPTIONS] or [HEAD, DELETE, POST, GET, OPTIONS, PUT, PATCH])

Any concerns allowing all the methods?

@jdno jdno mentioned this pull request Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdno jdno jdno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syphar @jdno