Update log format for release service on Fastly #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdno
force-pushed
the
log-release-traffic
branch
from
435d297 to
5725947
Compare
MarcoIeni
approved these changes
Sep 12, 2024
MarcoIeni
approved these changes
Sep 14, 2024
The log format of the Fastly service for releases has been slightly changed to set Datadog's unified tags[^1]. This makes it easier to work with the logs in Datadog's UI. [^1]: https://docs.datadoghq.com/getting_started/tagging/unified_service_tagging
We use a hierarchy of tags on Datadog to provide different means for filtering metrics and logs. All logs from a particular piece of infrastructure share the same `service` tag and then have different tags for the `env`. In this specific case, we want to tag everything as coming from the `static.rust-lang.org` service and then differentiate between the environments using the `dev` and `prod` valus for the environment.
The `host` attribute in the logs was not set properly, but is now being populated properly based in different information available in Fastly.
jdno
force-pushed
the
log-release-traffic
branch
from
d873700 to
132eb89
Compare
|
Rebased this to resolve a merge conflict with #569. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log format of the Fastly service for releases has been slightly changed to set Datadog's unified tags1. This makes it easier to work with the logs in Datadog's UI.
Footnotes
https://docs.datadoghq.com/getting_started/tagging/unified_service_tagging ↩