Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playground): provision ubuntu 24 ec2 #575

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

marcoieni
Copy link
Member

@marcoieni marcoieni commented Sep 24, 2024

We agreed in zulip to create a new EC2 with ubuntu 24 so that we can migrate to this one and delete the old one.

Plan:

Terraform will perform the following actions:

  # aws_eip.playground2 will be created
  + resource "aws_eip" "playground2" {
      + allocation_id        = (known after apply)
      + arn                  = (known after apply)
      + association_id       = (known after apply)
      + carrier_ip           = (known after apply)
      + customer_owned_ip    = (known after apply)
      + domain               = "vpc"
      + id                   = (known after apply)
      + instance             = (known after apply)
      + network_border_group = (known after apply)
      + network_interface    = (known after apply)
      + private_dns          = (known after apply)
      + private_ip           = (known after apply)
      + ptr_record           = (known after apply)
      + public_dns           = (known after apply)
      + public_ip            = (known after apply)
      + public_ipv4_pool     = (known after apply)
      + tags                 = {
          + "Name" = "playground2"
        }
      + tags_all             = {
          + "Name" = "playground2"
        }
      + vpc                  = (known after apply)
    }

  # aws_eip_association.playground2 will be created
  + resource "aws_eip_association" "playground2" {
      + allocation_id        = (known after apply)
      + id                   = (known after apply)
      + instance_id          = (known after apply)
      + network_interface_id = "eni-013da737e0f6aa60a"
      + private_ip_address   = (known after apply)
      + public_ip            = (known after apply)
    }

  # aws_instance.playground2 will be created
  + resource "aws_instance" "playground2" {
      + ami                                  = "ami-02ea6ff8f4d733569"
      + arn                                  = (known after apply)
      + associate_public_ip_address          = (known after apply)
      + availability_zone                    = (known after apply)
      + cpu_core_count                       = (known after apply)
      + cpu_threads_per_core                 = (known after apply)
      + disable_api_stop                     = (known after apply)
      + disable_api_termination              = true
      + ebs_optimized                        = true
      + get_password_data                    = false
      + host_id                              = (known after apply)
      + host_resource_group_arn              = (known after apply)
      + iam_instance_profile                 = "playground"
      + id                                   = (known after apply)
      + instance_initiated_shutdown_behavior = (known after apply)
      + instance_lifecycle                   = (known after apply)
      + instance_state                       = (known after apply)
      + instance_type                        = "c5a.large"
      + ipv6_address_count                   = (known after apply)
      + ipv6_addresses                       = (known after apply)
      + key_name                             = "buildbot-west-slave-key"
      + monitoring                           = false
      + outpost_arn                          = (known after apply)
      + password_data                        = (known after apply)
      + placement_group                      = (known after apply)
      + placement_partition_number           = (known after apply)
      + primary_network_interface_id         = (known after apply)
      + private_dns                          = (known after apply)
      + private_ip                           = (known after apply)
      + public_dns                           = (known after apply)
      + public_ip                            = (known after apply)
      + secondary_private_ips                = (known after apply)
      + security_groups                      = (known after apply)
      + spot_instance_request_id             = (known after apply)
      + subnet_id                            = (known after apply)
      + tags                                 = {
          + "Name" = "play-2"
        }
      + tags_all                             = {
          + "Name" = "play-2"
        }
      + tenancy                              = (known after apply)
      + user_data                            = (known after apply)
      + user_data_base64                     = (known after apply)
      + user_data_replace_on_change          = false
      + vpc_security_group_ids               = (known after apply)

      + network_interface {
          + delete_on_termination = false
          + device_index          = 0
          + network_card_index    = 0
          + network_interface_id  = "eni-013da737e0f6aa60a"
        }

      + root_block_device {
          + delete_on_termination = true
          + device_name           = (known after apply)
          + encrypted             = (known after apply)
          + iops                  = (known after apply)
          + kms_key_id            = (known after apply)
          + tags_all              = (known after apply)
          + throughput            = (known after apply)
          + volume_id             = (known after apply)
          + volume_size           = 100
          + volume_type           = "gp3"
        }
    }

  # aws_route53_record.playground2 will be created
  + resource "aws_route53_record" "playground2" {
      + allow_overwrite = (known after apply)
      + fqdn            = (known after apply)
      + id              = (known after apply)
      + name            = "play-2.infra.rust-lang.org"
      + records         = (known after apply)
      + ttl             = 60
      + type            = "A"
      + zone_id         = "Z237AC8WS9NFCS"
    }

Plan: 4 to add, 0 to change, 0 to destroy.

@marcoieni marcoieni force-pushed the feat-provision-ubuntu-24-playground-ec2 branch 3 times, most recently from d185ef3 to 9de0234 Compare September 24, 2024 09:46
@@ -5,6 +5,13 @@ resource "aws_eip" "playground" {
}
}

resource "aws_eip" "playground2" {
domain = "vpc"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aws recommends using domain instead of vpc = true.

screenshot:

image

@marcoieni marcoieni changed the title feat: provision ubuntu 24 playground ec2 feat(playground): provision ubuntu 24 ec2 Sep 24, 2024
@marcoieni marcoieni force-pushed the feat-provision-ubuntu-24-playground-ec2 branch from 9de0234 to 4e0b327 Compare September 24, 2024 09:48
@marcoieni marcoieni marked this pull request as ready for review September 24, 2024 09:48
@marcoieni marcoieni requested a review from jdno September 24, 2024 13:13
Copy link
Member

@jdno jdno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good, but we should make sure to decommission the current instance and remove the duplicate configuration once the switch is done.

@marcoieni
Copy link
Member Author

applied

@marcoieni marcoieni merged commit 78f1e4d into master Sep 25, 2024
3 checks passed
@marcoieni marcoieni deleted the feat-provision-ubuntu-24-playground-ec2 branch September 25, 2024 10:02
@marcoieni
Copy link
Member Author

marcoieni commented Sep 25, 2024

forgot to squash before merging 😵

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants