Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-desktops: Install npm #616

Merged
merged 1 commit into from
Oct 21, 2024
Merged

dev-desktops: Install npm #616

merged 1 commit into from
Oct 21, 2024

Conversation

aDotInTheVoid
Copy link
Member

NPM is used by rustdoc for the rustdoc-gui tests.

I have no way to check if this is correct/works.

Comment on lines 137 to 143
- name: Install Node
apt:
name: nodejs
name:
- nodejs
- npm
state: present
update_cache: yes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Install Node
apt:
name: nodejs
name:
- nodejs
- npm
state: present
update_cache: yes
- name: Install Node
apt:
name: {{ item }}
state: present
update_cache: yes
with_items:
- node
- npm

I think you need to wrap it in a loop (or just make two separate steps)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just using a list works for the main dependency step, so I think it's fine

- name: Install packages
apt:
name:
- apt-file # Allows showing the contents of packages which aren't installed
- build-essential
- clang
- cmake
- gcc-mingw-w64-x86-64 # Allows running `x check --target x86_64-pc-windows-gnu`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jdno jdno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh weird that no one complained yet that we only install Node and npm. 😅

@jdno jdno merged commit 33571f0 into rust-lang:master Oct 21, 2024
3 checks passed
@jdno
Copy link
Member

jdno commented Oct 30, 2024

This has been deployed to all dev-desktops. Feel free to give it a try and let me know if you run into any issues... 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants