Repository navigation
Return None from remaining_stack when off the cached stack - #156
Open
stevecrozz wants to merge 2 commits into
Open
stevecrozz wants to merge 2 commits into
stevecrozz wants to merge 2 commits into
Conversation
remaining_stack() subtracted the cached lowest address of the thread's stack from the stack pointer without checking that the stack pointer was on that stack. Hosts such as Ruby fibers and C coroutine libraries switch to stacks of their own, and there the result was 0 when the stack sat below the thread's stack, or more than the stack's whole size when it sat above it, which keeps maybe_grow from growing before an overflow. Cache both ends of the stack and return None when the stack pointer is outside them. maybe_grow already grows when the remaining stack is unknown.
psm::on_stack doesn't exist on Windows or under Miri, so the tests failed to compile there.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remaining_stack() subtracted the cached lowest address of the thread's stack from the stack pointer without checking that the stack pointer was on that stack. Hosts such as Ruby fibers and C coroutine libraries switch to stacks of their own, and there the result was 0 when the stack sat below the thread's stack, or more than the stack's whole size when it sat above it, which keeps maybe_grow from growing before an overflow.
Cache both ends of the stack and return None when the stack pointer is outside them. maybe_grow already grows when the remaining stack is unknown.