Skip to content

Add runtime detection for new AMX variants and MOVRS #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

sayantn
Copy link
Contributor

@sayantn sayantn commented Apr 1, 2025

See rust-lang/rust#138003 and rust-lang/rust#137976

Updates SDE to v9.53.0

For some reason intel-sde/misc/cpuid/future/cpuid.def has not been updated, so I am temporarily using intel-sde/misc/cpuid/dmr/cpuid.def with some edits.

TODO: When Intel fixes their intel-sde/misc/cpuid/future/cpuid.def, revert to using that

Fixes: In cpus which have amx, but not avx512, amx didn't show up in is_x86_feature_detected!

Also removed the without cfg check clause from a few riscv target features because they got merged in the compiler

@rustbot
Copy link
Collaborator

rustbot commented Apr 1, 2025

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@sayantn sayantn force-pushed the new-amx-movrs branch 2 times, most recently from 1a7ca47 to c8f533c Compare April 3, 2025 10:00
@sayantn sayantn marked this pull request as ready for review April 3, 2025 10:00
@Amanieu Amanieu added this pull request to the merge queue Apr 7, 2025
Merged via the queue into rust-lang:master with commit 1aca4dd Apr 7, 2025
60 checks passed
@sayantn sayantn deleted the new-amx-movrs branch April 7, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants