Exclude gcc submodule from thanksbot (similar to llvm)#69
Merged
emilyalbini merged 1 commit intorust-lang:masterfrom Sep 16, 2024
Merged
Exclude gcc submodule from thanksbot (similar to llvm)#69emilyalbini merged 1 commit intorust-lang:masterfrom
emilyalbini merged 1 commit intorust-lang:masterfrom
Conversation
Noratrieb
approved these changes
Sep 16, 2024
Member
Noratrieb
left a comment
Noratrieb
left a comment
There was a problem hiding this comment.
0/10 this makes Richard Stallman no longer a Rust contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we're now treating
gccas a submodule (rust-lang/rust#125419) we're now including all gcc changes from all time. I think that's a bit unfair for rust contributors, since while gcc is a cool project, it's not (yet /hj) rust.I wondered to myself why this wasn't happening for our llvm submodule (which also includes many many commits that are specifically not Rust-related), and it turns out we explicitly exclude the llvm submodule in thanksbot. This PR does the same for gcc.