linux: dso_debug: add a MainExecutable struct - #229
Merged
Merged
Conversation
schopin-mozilla
force-pushed
the
dso-main-exec
branch
from
September 8, 2026 10:53
0d35e27 to
723985f
Compare
gabrielesvelto
approved these changes
Sep 8, 2026
gabrielesvelto
left a comment
gabrielesvelto
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just one small nit
schopin-mozilla
force-pushed
the
dso-main-exec
branch
2 times, most recently
from
September 11, 2026 14:56
1005fa2 to
357f504
Compare
This allows us to split out the code in smaller bits, which will come in handy later on. There's a drive-by fix, where we stop relying on page boundaries and instead compute the actual load bias of the executable. This fixes support for non-4kB page sizes.
schopin-mozilla
force-pushed
the
dso-main-exec
branch
from
September 14, 2026 11:14
357f504 to
0d6aef3
Compare
schopin-mozilla
removed this pull request from stack #236
September 14, 2026 16:22
schopin-mozilla
added this pull request to stack #242
September 14, 2026 16:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to split out the code in smaller bits, which will come in
handy later on.
There's a drive-by fix, where we stop relying on page boundaries and
instead compute the actual load bias of the executable. This fixes
support for non-4kB page sizes.
Stack created with GitHub Stacks CLI • Give Feedback 💬