-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split things into different files, to optimize future work #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea! rustfmt
still needs to be ran and I think that should be(come) a requirement in the CI?
EDIT: I didn't really vet the changes at all but trust you moved it completely - CI is happy so the imports / module references should all be good.
I have added basic rustfmt config. Other PRs can take care of that if that's important. |
Oh I didn't need a I meant running it in CI to reject changes if they don't adhere to the (default!) formatting standard, instead of causing unnecessary reformatting churn later on. |
It's ok I formatted with rustfmt now :) |
Oh yeah I trust that you formatted it now, just thinking it'd be nice to validate this in CI going forward for future contributions and pushes, as done in #86 :) |
Not much change besides the simple divide and conquer.