Remove Nonstatic Zip & Reqwest

[lolpro11]

This does not affect the functionality of the crate, as this does not use zstd. Same thing with using rust-tls. We are just switching tls libraries.
These changes will allow a static compile of this library.

[antoine-de]

fine for me, thanks for this!

[Tristramg]

I’d be a bit more cautious concerning the compression algorithm support. We use zip to read files generated by others.
It would be annoying if there are some zip files that can not be read anymore; multiple formats seem to used, not only deflate: https://en.wikipedia.org/wiki/ZIP_(file_format)#Compression_methods

No problem for rust-tls

[lolpro11]

Update: I patched zip to use only Rust versions of bzip2 and zstd, thereby allowing rustc to compile this lib statically

[antoine-de]

We cannot depend directly on a git dependency, we need something properly published on crates.io

By curiosity, would do you need this?

[lolpro11]

We cannot depend directly on a git dependency, we need something properly published on crates.io

By curiosity, would do you need this?

I am waiting on an upstream PR with zip. Also, I do need this so I can run this in a container.
Let me try to find another solution

[kylerchin]

We cannot depend directly on a git dependency, we need something properly published on crates.io

By curiosity, would do you need this?

I completely agree with this.

[lolpro11]

I’d be a bit more cautious concerning the compression algorithm support. We use zip to read files generated by others. It would be annoying if there are some zip files that can not be read anymore; multiple formats seem to used, not only deflate: https://en.wikipedia.org/wiki/ZIP_(file_format)#Compression_methods

No problem for rust-tls

• Store (no compression),
• Shrink (LZW),
• Reduce (levels 1–4; LZ77 + probabilistic),
• Implode,
• Deflate,
• Deflate64,
• bzip2,
• LZMA,
• WavPack,
• PPMd,
• LZ77 variant provided by IBM z/OS CMPSC instruction

[lolpro11]

@Tristramg Are you sure we need support for bzip and zstd? I did a compression method check on Transitland's database and it looks like they don't have a single file with bzip or zstd.
GTFScompression.log

[dkter]

I patched it to allow disabling of bzip and zstd via a feature, this shouldn't break anything by default since the feature is enabled by default: dkter@cf41895

If needed I can make another PR

[lolpro11]

I patched it to allow disabling of bzip and zstd via a feature, this shouldn't break anything by default since the feature is enabled by default: dkter@cf41895

If needed I can make another PR

Can you make another PR for this? That would be great. Also, what do you intend on doing for rust-tls?

[dkter]

Also, what do you intend on doing for rust-tls?

I'm able to use default-tls for my use case but could re-export these if helpful?

reqwest-default = ["reqwest/default"]
reqwest-rustls-tls = ["reqwest/rustls-tls"]

[lolpro11]

I'm able to use default-tls for my use case but could re-export these if helpful?

reqwest-default = ["reqwest/default"]
reqwest-rustls-tls = ["reqwest/rustls-tls"]

Yeah, that looks good! Thanks. Let me know when you have the PR done so I can close this one.

[dkter]

#163