Make route colors optional

[jbruechert]

When generating feeds using the structures from gtfs_structures, it is
desirable to be able to serialize an empty column.

I suspect it is also relevant to know on the comsumer side wether black
is a brand color or a fallback.

This change is a an API break.

[antoine-de]

Seems a bit more difficult to use, but I agree with you that this is better for serialization.

if someone needs it, maybe we can add getter like

fn route_color(&self) -> RGB8 { self.route_color.unwrap_or(DEFAULT_ROUTE_COLOR) }

[antoine-de]

If you want it to be released right away, can you update the version (to 0.45.0 since it's a breaking change)?

[jbruechert]

Seems a bit more difficult to use, but I agree with you that this is better for serialization.

if someone needs it, maybe we can add getter like

fn route_color(&self) -> RGB8 { self.route_color.unwrap_or(DEFAULT_ROUTE_COLOR) }

Makes sense! I'll add that and update the tests.

[antoine-de]

thanks!

[antoine-de]

oups clippy seems unhappy with the string format (I don't really agree with it here, but it's nice to keep the lints).

can you make the change ? else I'll do it.

[jbruechert]

oups clippy seems unhappy with the string format (I don't really agree with it here, but it's nice to keep the lints).

can you make the change ? else I'll do it.

done

[jbruechert]

Is there anything else I need to do?

[antoine-de]

oups, no sorry, I was in holiday without a connection.

thanks for the contribution!

[jbruechert]

Ah no problem, I hope you enjoyed your holidays :)