Error compiling to Android with cargo apk #1307 #1385
Closed
philipp-kaiser wants to merge 6 commits intorust-windowing:masterfrom
Closed
Error compiling to Android with cargo apk #1307 #1385philipp-kaiser wants to merge 6 commits intorust-windowing:masterfrom
philipp-kaiser wants to merge 6 commits intorust-windowing:masterfrom
Conversation
…returned 0x{:x})",
|
Any updates on this? |
7 tasks
Member
|
Thanks for working on reviving Android support! Unfortunately this PR is only commenting out non-compiling code instead of actively fixing the issue at hand. #1398 is a first - approved - stab at resolving compiler errors, and I have some work queued up that addresses the remainder of event issues with newer winit, to be submitted after that PR is merged. As such there's no need for this PR anymore, but I hope you'll stick around to test the upcoming changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to usersThis merge request addresses the endless unresolved build errors when trying to compile with cargo apk for android.
#1307
There is an open merge request on winit crate:
rust-windowing/winit#2118
If that request is merged, we can finally resolve this bug. But before merging, we need to adjust the winit version in cargo toml. I just want to created this request to address this also on winit side.
Working examples with both fixes can be found here:
https://github.com/Kaiser1989/rust-android-example
https://github.com/Kaiser1989/game-gl