Fixes android symbol loader not having is_loaded (build error)#1407
Closed
lattice0 wants to merge 3 commits intorust-windowing:masterfrom
lattice0:master
Closed
Fixes android symbol loader not having is_loaded (build error)#1407lattice0 wants to merge 3 commits intorust-windowing:masterfrom lattice0:master
is_loaded (build error)#1407lattice0 wants to merge 3 commits intorust-windowing:masterfrom
lattice0:master
Conversation
Author
|
Hello, before I fix the CI/CD stuff and the missing checkboxes, can I know if something's missing? I think these changes fix the problem. Android seems to not have dynamic loading of dynamically loadable libs so there's no |
Author
|
PS: all testes failed because I pointed to a local winit for my stuff. Gonna fix it soon but currently maybe leave like this so my local project works, is there a problem? just want to keep things simple |
MarijnS95
reviewed
May 21, 2022
MarijnS95
reviewed
May 21, 2022
is_loaded (build error)
7 tasks
Member
|
FYI this is going to get closed when #1398 is merged, which turns out to be a better solution to this problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1307
cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to users