Use get_instance_handle() over GetModuleHandle(NULL)#1446
Closed
SamRodri wants to merge 1 commit intorust-windowing:masterfrom
SamRodri:get-module-fix
Closed
Use get_instance_handle() over GetModuleHandle(NULL)#1446SamRodri wants to merge 1 commit intorust-windowing:masterfrom SamRodri:get-module-fix
SamRodri wants to merge 1 commit intorust-windowing:masterfrom
SamRodri:get-module-fix
Conversation
See the [winit](rust-windowing/winit#2301) discussion on this fix
Author
|
I see that there is a major rewrite underway, maybe @kchibisov can copy this patch into his pull request? |
Member
|
Actually, I don't think I need this patch at all on my branch. I just need to use I'm not sure how I feel about adding this patch right now given that I'm unlikely to make a glutin release. Is there a strong need for this patch or you can wait like a few more weeks and update to my rework given that it's nearly complete already? |
Author
|
No rush on my part, I can depend on my fork until your update is released. |
Member
|
Handled in #1435. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the winit discussion about this fix.
fixes #1445
cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to users