Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Generate minimal-versions when build-testing MSRV #260

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CI: Generate minimal-versions when build-testing MSRV #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,29 @@ jobs:
with:
tool: wasm-bindgen-cli

- name: Install nightly rust to generate `-Zminimal-versions` lockfile (for MSRV)
if: matrix.rust_version == '1.71.0'
uses: dtolnay/rust-toolchain@master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Use hecrj/setup-rust-action@v2 (or change both places to use the same).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe eschew a GitHub Action-thing, and just do rustup install nightly-... in the bash script below

with:
toolchain: nightly-2024-10-01

- name: Pin deps that break MSRV
if: matrix.rust_version == '1.71.0'
# By downgrading all our dependency versions, we ensure that our minimum
# version bounds are actually adequate (i.e. users can build `softbuffer`
# with minimal versions themselves) and opt-out of any unexpected MSRV
# bumps in semver-compatible releases of downstream crates.
run: |
cargo -Zminimal-versions generate-lockfile
# Bump `regex` - only used by our `dev-dependencies` `criterion` dependency - to fix:
# https://github.com/rust-lang/regex/issues/931
# Can be removed on the next `criterion` upgrade: https://github.com/bheisler/criterion.rs/pull/821
cargo update -p regex --precise 1.5.1
cargo update -p num-traits --precise 0.2.16 # Unconditional i128 support used by image
cargo update -p anyhow --precise 1.0.19 # walrus needs bail!() string support from 1.0.1, wasm-bindgen-cli-support requires format_err from 1.0.19
cargo update -p foreign-types-macros --precise 0.2.2 # `core-graphics 0.23.1` from `winit 0.30` fails to compile on 0.2.1
cargo update -p same-file --precise 1.0.5 # First release with `unknown` support for wasm32

- uses: hecrj/setup-rust-action@v2
with:
rust-version: ${{ matrix.rust_version }}${{ matrix.platform.host }}
Expand All @@ -95,11 +118,6 @@ jobs:
if: (matrix.platform.os == 'ubuntu-latest') && contains(matrix.platform.target, 'i686')
run: sudo apt-get install gcc-multilib

- name: Pin deps that break MSRV
if: matrix.rust_version == '1.71.0'
run: |
cargo update -p bumpalo --precise 3.14.0

- name: Build crate
shell: bash
run: cargo $CMD build --verbose --target ${{ matrix.platform.target }} $OPTIONS --features $FEATURES
Expand Down