Skip to content

iOS: Fix a few instances of UB#2428

Merged
madsmtm merged 2 commits intorust-windowing:masterfrom
madsmtm:fix-ios-ub
Sep 1, 2022
Merged

iOS: Fix a few instances of UB#2428
madsmtm merged 2 commits intorust-windowing:masterfrom
madsmtm:fix-ios-ub

Conversation

@madsmtm
Copy link
Member

@madsmtm madsmtm commented Aug 12, 2022

Mostly interesting for 32-bit iOS.

Found while making #2427.

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@madsmtm madsmtm added B - bug Dang, that shouldn't have happened DS - uikit Affects the UIKit backend (iOS, tvOS, watchOS, visionOS) labels Aug 12, 2022
@madsmtm madsmtm requested a review from august64 as a code owner August 12, 2022 19:23
@madsmtm madsmtm changed the title iOS: Fix a few instance of UB iOS: Fix a few instances of UB Aug 12, 2022
@august64
Copy link
Member

Sorry for the delay! This LGTM, but I'm currently unemployed and therefore no longer have any iOS devices to test on.

@ArthurKValladares would you mind taking a look at this?

@madsmtm madsmtm merged commit a43a15b into rust-windowing:master Sep 1, 2022
@madsmtm
Copy link
Member Author

madsmtm commented Sep 1, 2022

I merged this as per discussion in #2451

@madsmtm madsmtm deleted the fix-ios-ub branch September 1, 2022 01:10
kchibisov pushed a commit to kchibisov/winit that referenced this pull request Sep 9, 2022
* Fix iOS 32-bit

* Fix a few invalid message sends on iOS
kchibisov pushed a commit that referenced this pull request Sep 11, 2022
* Fix iOS 32-bit

* Fix a few invalid message sends on iOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B - bug Dang, that shouldn't have happened DS - uikit Affects the UIKit backend (iOS, tvOS, watchOS, visionOS)

Development

Successfully merging this pull request may close these issues.

2 participants