Accepts first mouse

[mgax]

• Tested on all platforms changed
• Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
• Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
• Created or updated an example program if it would help users understand this functionality
• Updated feature matrix, if new features were added or implemented

---

Quoting #1882 (review):

At some point we should consider making it user-configurable, but let's wait until someone comes with a concrete use-case!

The use case is for Neovide (neovide/neovide#1343), so it behaves more like a native MacOS application.

[mgax]

CI is failing with a type mismatch between bool and BOOL. I've added as BOOL to the return value; I hope it's the right thing to do, and the unsafe block isn't hiding anything unsafe :)

---

Edit: I'm running on arm64 where it seems bool and BOOL are the same type, but the CI is running on x86_64.

[madsmtm]

This looks good, thanks!

If you don't mind, I think I'll wait with this 'till #2427 is done, at which point the bool stuff should also be easier.

[mgax]

If you don't mind, I think I'll wait with this 'till #2427 is done, at which point the bool stuff should also be easier.

I don't mind. But it's sorted out – at least, the CI is happy :)

[mgax]

I've updated the branch. The new #[sel(acceptsFirstMouse:)] syntax is pretty neat.

I think the tests failed because of GitHub; one just says Error: Internal Server Error. I'd re-run it but I don't have permission. @madsmtm can you trigger a re-run? Or should I just push an empty commit?

[madsmtm]

Apologies, I should have been more clear, I wasn't actually ready with #2427 yet.

Could I get you to merge the latest master, and then move accepts_first_mouse from ViewState to WinitView (would do it myself, but I don't have write access to your branch).

[mgax]

Apologies, I should have been more clear, I wasn't actually ready with #2427 yet.

No worries! I'm not used to working with Rust or Objective-C and it's fun to follow along while you refactor the internals :)

I hope I got it right with storing the flag on SharedState, that's what other flags seem to be doing.

[madsmtm]

Wonderful, only small nits

[madsmtm]

Thanks!

[madsmtm]

I had to fix the changelog entry beforehand but still didn't seem to have access to the branch, idk. maybe I'm doing something wrong, so ended up merging this manually in 48b843e instead.

[mgax]

@madsmtm thanks for seeing this through!