Skip to content

macOS: Fix overridden fullscreen selectors#2546

Merged
madsmtm merged 1 commit intomasterfrom
fix-macos-fullscreen
Nov 3, 2022
Merged

macOS: Fix overridden fullscreen selectors#2546
madsmtm merged 1 commit intomasterfrom
fix-macos-fullscreen

Conversation

@madsmtm
Copy link
Member

@madsmtm madsmtm commented Nov 2, 2022

Fixes #2520

These were incorrectly named (Fullscreen instead of FullScreen, notice the big "S").

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@madsmtm madsmtm added B - bug Dang, that shouldn't have happened DS - appkit Affects the AppKit/macOS backend labels Nov 2, 2022
@rofferom
Copy link

rofferom commented Nov 3, 2022

Works on my machine 👍

@madsmtm madsmtm merged commit 97d4c7b into master Nov 3, 2022
@madsmtm
Copy link
Member Author

madsmtm commented Nov 3, 2022

For reference: I'm working on things in objc2 that could help catching mistakes like these in the future

@madsmtm madsmtm deleted the fix-macos-fullscreen branch November 3, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B - bug Dang, that shouldn't have happened DS - appkit Affects the AppKit/macOS backend

Development

Successfully merging this pull request may close these issues.

macOS fullscreen toggle is broken

2 participants