-
Notifications
You must be signed in to change notification settings - Fork 1k
wayland: Add WindowExtWayland::xdg_toplevel
#4076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ultimaweapon
wants to merge
7
commits into
rust-windowing:master
Choose a base branch
from
ultimaweapon:wayland
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7c8585f
wayland: Add WindowExtWayland::xdg_toplevel
ultimaweapon 0c671f2
wayland: fix docs on non-wayland platforms
ultimaweapon d854ab8
wayland: change return type of WindowExtWayland::xdg_toplevel to Opti…
ultimaweapon fdce562
wayland: move WindowExtWayland implementation
ultimaweapon 8ec4d2c
doc: add changelog for WindowExtWayland::xdg_toplevel
ultimaweapon 5d3801f
wayland: do not panic in WindowExtWayland::xdg_toplevel implementation
ultimaweapon 5540a4c
Merge branch 'master' into wayland
kchibisov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you move this logic to
wayland/window/mod.rs
and return pointer from there instead, so we don't have an export here. We could also not fail when we can notcast
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Sorry I don't understand what you mean. Do you mean we should use
NonNull::new_unchecked
instead ofNonNull::new
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, that you just forward option up and not panic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.