Skip to content

x11: implement set_override_redirect#4125

Open
lunixbochs wants to merge 1 commit intorust-windowing:masterfrom
talonvoice:set-override-redirect
Open

x11: implement set_override_redirect#4125
lunixbochs wants to merge 1 commit intorust-windowing:masterfrom
talonvoice:set-override-redirect

Conversation

@lunixbochs
Copy link
Copy Markdown
Contributor

@lunixbochs lunixbochs commented Feb 11, 2025

  • Tested on all platforms changed
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

implements window.set_override_redirect() for x11 so it can be updated after the window is created
(Note: I just ported this from my 0.30 branch to master without retesting and I'm not sure on the WindowExtX11 downcast)

Copy link
Copy Markdown
Member

@kchibisov kchibisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a CHANGELOG entry.

Comment thread src/platform_impl/linux/x11/window.rs Outdated
Comment thread src/platform/x11.rs Outdated
@lunixbochs
Copy link
Copy Markdown
Contributor Author

added changelog entry and addressed comments

Copy link
Copy Markdown
Contributor

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash all of these commits together.

Comment thread src/platform/x11.rs
Comment thread src/platform_impl/linux/x11/window.rs Outdated
@lunixbochs lunixbochs force-pushed the set-override-redirect branch from a9b67cd to 72dc152 Compare February 19, 2025 02:58
@lunixbochs lunixbochs requested a review from notgull February 19, 2025 02:59
@madsmtm madsmtm added DS - x11 Affects the X11 backend, or generally free Unix platforms S - platform parity Unintended platform differences labels Feb 24, 2025
@lunixbochs lunixbochs force-pushed the set-override-redirect branch from 72dc152 to 504c261 Compare March 10, 2025 14:00
@lunixbochs
Copy link
Copy Markdown
Contributor Author

bumping

@kchibisov
Copy link
Copy Markdown
Member

You need to rebase though.

@lunixbochs
Copy link
Copy Markdown
Contributor Author

lunixbochs commented Apr 19, 2026

I would greatly prefer to not keep rebasing the four PRs I've had outstanding for over a year. Last time you asked me to rebase, you did not merge or reply after I rebased: #4123 (comment)

Here, you suggested I have the maintainer do it at merge time: #3997 (comment)

I would prefer if a maintainer looks at my four outstanding PRs and performs the rebase at the time they merge.

https://github.com/talonvoice/winit/tree/0.30 has these changes recently rebased onto 0.30 if that makes the process easier.

@kchibisov
Copy link
Copy Markdown
Member

Well, I can not rebase myself since I don't have permission, so I can not merge it.

If you can give permission maintainers to push to your things then I would have done all that myself and merged...

I would prefer if a maintainer looks at my four outstanding PRs and performs the rebase at the time they merge.

Well, then you should enable an option, since you disallow maintainers to do so.

@lunixbochs
Copy link
Copy Markdown
Contributor Author

I didn't explicitly disable maintainer edits, it looks like they're just not supported with cross-org PRs: https://github.com/orgs/community/discussions/5634

I granted you permissions directly on my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DS - x11 Affects the X11 backend, or generally free Unix platforms S - platform parity Unintended platform differences

Development

Successfully merging this pull request may close these issues.

4 participants