x11: implement set_override_redirect#4125
x11: implement set_override_redirect#4125lunixbochs wants to merge 1 commit intorust-windowing:masterfrom
Conversation
da2f4b1 to
ab336cd
Compare
|
added changelog entry and addressed comments |
notgull
left a comment
There was a problem hiding this comment.
Please squash all of these commits together.
a9b67cd to
72dc152
Compare
72dc152 to
504c261
Compare
504c261 to
03bab6a
Compare
|
bumping |
|
You need to rebase though. |
|
I would greatly prefer to not keep rebasing the four PRs I've had outstanding for over a year. Last time you asked me to rebase, you did not merge or reply after I rebased: #4123 (comment) Here, you suggested I have the maintainer do it at merge time: #3997 (comment) I would prefer if a maintainer looks at my four outstanding PRs and performs the rebase at the time they merge. https://github.com/talonvoice/winit/tree/0.30 has these changes recently rebased onto 0.30 if that makes the process easier. |
|
Well, I can not rebase myself since I don't have permission, so I can not merge it. If you can give permission maintainers to push to your things then I would have done all that myself and merged...
Well, then you should enable an option, since you disallow maintainers to do so. |
|
I didn't explicitly disable maintainer edits, it looks like they're just not supported with cross-org PRs: https://github.com/orgs/community/discussions/5634 I granted you permissions directly on my fork. |
changelogmodule if knowledge of this change could be valuable to usersimplements
window.set_override_redirect()for x11 so it can be updated after the window is created(Note: I just ported this from my 0.30 branch to master without retesting and I'm not sure on the WindowExtX11 downcast)