Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): support for 3.12 #158

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

vkurilin
Copy link
Contributor

@vkurilin vkurilin commented Dec 5, 2023

Closes #157

@francium
Copy link
Member

francium commented Dec 5, 2023

Thanks.

I think there's a few files however we still need to update.
See this PR for 3.11, https://github.com/rustedpy/result/pull/107/files, for reference

@vkurilin vkurilin force-pushed the feat/python/support-for-3.12 branch from 8ada377 to 7555ef4 Compare December 5, 2023 18:50
@vkurilin
Copy link
Contributor Author

vkurilin commented Dec 5, 2023

Thanks!

I've added [Unreleased] record to the changelog and fixed tox.ini, but I don’t understand how to correctly use the test_result.yaml file

@francium
Copy link
Member

francium commented Dec 5, 2023

You should be able to run pytest and it should pick up the yaml test. But as long as the PR passes checks, I don't know if we need any changes to the yaml file.

Thanks, I'll review this and test this myself when I get the chance.

@vkurilin
Copy link
Contributor Author

vkurilin commented Dec 5, 2023

Oh, cool, I didn't even know there was a way to run tests like that

type-checking/test_result.yml::failure_lash PASSED
type-checking/test_result.yml::covariance PASSED
type-checking/test_result.yml::map_ok_err PASSED
type-checking/test_result.yml::map_result PASSED
type-checking/test_result.yml::map_result PASSED

These tests pass, so we have fixed everything that needed =)

@francium francium merged commit 3994af7 into rustedpy:master Dec 8, 2023
5 checks passed
@francium
Copy link
Member

francium commented Dec 8, 2023

Thanks for the help @vkurilin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formal support for 3.12
2 participants