Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference type and make_ref call #657

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Add reference type and make_ref call #657

merged 3 commits into from
Oct 15, 2024

Conversation

filmor
Copy link
Member

@filmor filmor commented Oct 13, 2024

This is a first step towards #95.

enif_make_ref is the only direct rustler_sys reference I could find on github outside of rustler itself (in extorch). Since #653 is a potentially breaking change for direct users of rustler_sys (at least on Windows, where the initialisation won't get called anymore), this code needs to be adjusted on upgrade anyhow, so it makes sense to add the used functionality directly.

@filmor filmor merged commit d658ae2 into master Oct 15, 2024
46 checks passed
@filmor filmor deleted the references branch October 15, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant