Skip to content

Lower minimum Rust version from 1.92 to 1.91 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
overtrue merged 3 commits into from
Feb 24, 2026
Merged

Lower minimum Rust version from 1.92 to 1.91 #18

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9303451
Initial plan
Copilot Feb 24, 2026
52949c6
chore: lower rust-version from 1.92 to 1.88
Copilot Feb 24, 2026
f39a0bc
chore: update rust-version to 1.91 to match Alpine 3.23
Copilot Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ members = ["crates/cli", "crates/core", "crates/s3"]
[workspace.package]
version = "0.1.3"
edition = "2024"
rust-version = "1.92"
rust-version = "1.88"

Copilot AI Feb 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MSRV has been updated to 1.88 in Cargo.toml, but several other files still reference the old 1.92 version and need to be updated for consistency:

  1. .github/workflows/ci.yml line 119 - The MSRV CI job still uses toolchain "1.92"
  2. Dockerfile line 1 - Uses rust:1.92.0-alpine3.23 base image
  3. README.md line 293 - Documents "Rust 1.92 or higher"
  4. CHANGELOG.md line 25 - States "Updated minimum supported Rust version (MSRV) to 1.92"

All these references should be updated to 1.88 to match this change. The inconsistency could cause CI failures and confusion for users.

Copilot uses AI. Check for mistakes.
license = "MIT OR Apache-2.0"
repository = "https://github.com/rustfs/cli"
homepage = "https://github.com/rustfs/cli"
Expand Down