-
Notifications
You must be signed in to change notification settings - Fork 13
feat(phase-2): add jq and yq to rc docker image #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| //! Dockerfile runtime tooling contract tests. | ||
| //! | ||
| //! These tests prevent regressions where container utility tools expected by | ||
| //! users (for example in Kubernetes jobs) are removed from the runtime image. | ||
|
|
||
| use std::path::PathBuf; | ||
|
|
||
| fn workspace_root() -> PathBuf { | ||
| PathBuf::from(env!("CARGO_MANIFEST_DIR")) | ||
| .parent() | ||
| .expect("cli crate has parent directory") | ||
| .parent() | ||
| .expect("workspace root exists") | ||
| .to_path_buf() | ||
| } | ||
|
|
||
| fn dockerfile_contents() -> String { | ||
| let dockerfile_path = workspace_root().join("Dockerfile"); | ||
| std::fs::read_to_string(&dockerfile_path) | ||
| .unwrap_or_else(|err| panic!("failed to read {}: {err}", dockerfile_path.display())) | ||
| } | ||
|
|
||
| #[test] | ||
| fn runtime_image_installs_jq_and_yq() { | ||
| let contents = dockerfile_contents(); | ||
| let runtime_apk_line = contents | ||
| .lines() | ||
| .rev() | ||
| .find(|line| line.contains("apk add --no-cache")) | ||
| .expect("Dockerfile should install runtime packages with apk"); | ||
|
|
||
| assert!( | ||
| runtime_apk_line.contains("jq"), | ||
| "runtime apk install line should include jq; found: {runtime_apk_line}" | ||
| ); | ||
| assert!( | ||
| runtime_apk_line.contains("yq"), | ||
| "runtime apk install line should include yq; found: {runtime_apk_line}" | ||
| ); | ||
|
overtrue marked this conversation as resolved.
Outdated
|
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.