fix(fault): log dm-flakey guard cleanup failures instead of discarding#24
Merged
Conversation
DmFlakeyGuard::drop discarded both the recovery-table restore and the helper-pod delete with `let _ =`. A silently-dropped restore leaves the injected fault table live on a real block device; a dropped delete leaks the privileged helper pod. PR #16 established this logged-cleanup pattern for ChaosGuard (chaos CRs) but the more dangerous host backend never got it. Surface both failures via eprintln with node/target/pod context so the leak is visible to operators, matching ChaosGuard::drop.
overtrue
force-pushed
the
fix/host-backend-logged-drop
branch
from
July 12, 2026 02:15
c511de7 to
2669a6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DmFlakeyGuard::dropdiscarded both cleanup steps withlet _ =:A silently-dropped restore leaves the injected fault table live on a real block device on the target node; a dropped delete leaks the privileged (
hostPID+ host-root-mounted) helper pod. Both are exactly the leak class #16 hardened — it added the logged-cleanup pattern toChaosGuard::dropfor chaos CRs, but the host/device-mapper backend (the most dangerous one, since it mutates a real block device) never received it.This surfaces both failures via
eprintln!with node/target/pod context, matchingChaosGuard::dropverbatim in style. Behaviour is otherwise unchanged — a successful cleanup path is identical; only the previously-swallowed error cases now emit an operator-visible warning.Validation
cargo fmt --allcleancargo clippy --all-targetscleancargo test— 236 + 15 pass, 0 failuresFollow-up to #16; part of the s3chaos review tracked in rustfs/backlog#1100.