Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reported issues in multiple packages #1770

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

shinmao
Copy link
Contributor

@shinmao shinmao commented Sep 7, 2023

No description provided.

@shinmao
Copy link
Contributor Author

shinmao commented Sep 7, 2023

Sorry for sending PRs for several times. I finally find out how to check all the failed lints together.

# Allows uninitialized memory exposure in safe function
The safe function `push` allows users to cast arbitrary types as bytes. If user provides a `struct` type with padding bytes, it could violate the safety guarantee of `func` and expose the uninitialized memory.

Note: The crate is not maintained anymore.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is the case, a seperate unmaintained advisory would be more appropriate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I think my case is similar to this one: RUSTSEC-2023-0055, so I only mentioned it in advisories. Or I can update it again if you want?

@alex
Copy link
Member

alex commented Sep 7, 2023

Looks like quite a few of these are unfixed with no response from maintainers. Can someone remind me what our usual policy for those cases is?

@Shnatsel
Copy link
Member

Shnatsel commented Sep 7, 2023

Last time we have settled on #1092 (comment)

So it requires advance notice and a grace period for the maintainers to be able to take action before the advisory goes live.

@shinmao
Copy link
Contributor Author

shinmao commented Sep 13, 2023

For the crate zub, we have got response that it is unmaintained for a while(nilq/zub-vm#14 (comment)). I think the code will not be patched.

@shinmao
Copy link
Contributor Author

shinmao commented Sep 22, 2023

Hi, @alex @Shnatsel . Is there any update for this PR?

@shinmao shinmao requested a review from alex May 23, 2024 21:29
@shinmao shinmao marked this pull request as draft June 4, 2024 01:54
@shinmao shinmao marked this pull request as ready for review June 4, 2024 01:55
@shinmao
Copy link
Contributor Author

shinmao commented Jun 4, 2024

hi @alex , I am wondering the progress of this PR so far. If the PR has some wrong format then it should be rejected so that I can correct the issues:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants