-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update postgres:16.3 docker digest to d0f363f - abandoned #1999
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore: modify cert, key, registry to download * chore(test): write test for web methods * chore(deps): update dependencies * chore(test): add test for generateShardList * Add .env.example file and update docker-compose.yml***
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore: pin images to version * chore: remove sha
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change in the docker-compose.yml file alters the Docker image of the postgres service. It's crucial to discuss such changes with the team and to ensure that everyone is aware, as this affects the environment in which your application runs. Make sure the new Docker image is thoroughly tested to ensure it doesn't break anything. If the change is necessary, it's satisfactory.
docker-compose.yml
Outdated
@@ -11,7 +11,7 @@ services: | |||
extra_hosts: | |||
- "host.docker.internal:host-gateway" | |||
db: | |||
image: postgres:16.3@sha256:0aafd2ae7e6c391f39fb6b7621632d79f54068faebc726caf469e87bd1d301c0 | |||
image: postgres:16.3@sha256:008cbc50538f82e3cad5e7c82ec726be197c4dddc64507d1d652ac8b18213d3b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Docker image of the PostgreSQL database has been changed. Are we sure this new image (sha256:008cbc50538f82e3cad5e7c82ec726be197c4dddc64507d1d652ac8b18213d3b) is reliable and won't cause any issues? Has it been thoroughly tested? Changing Docker images can lead to unexpected compatibility issues, so we need to proceed with caution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in the provided Git diff affect only the image hash of the Postgres instance used in a Docker Compose file. This suggests that the Postgres image was updated to a newer version. Generally, this is a good practice to include the image hash along with the version as it makes the setup more deterministic and secure. However, it raises a few concerns that should be addressed.
docker-compose.yml
Outdated
@@ -11,7 +11,7 @@ services: | |||
extra_hosts: | |||
- "host.docker.internal:host-gateway" | |||
db: | |||
image: postgres:16.3@sha256:0aafd2ae7e6c391f39fb6b7621632d79f54068faebc726caf469e87bd1d301c0 | |||
image: postgres:16.3@sha256:008cbc50538f82e3cad5e7c82ec726be197c4dddc64507d1d652ac8b18213d3b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document the reason for changing the Postgres image. If the new image includes updates or security patches, mention them explicitly in the commit message.
Here's the code health analysis summary for commits Analysis Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1999 +/- ##
=======================================
Coverage 10.51% 10.51%
=======================================
Files 97 97
Lines 8503 8503
Branches 115 115
=======================================
Hits 894 894
Misses 7609 7609
☔ View full report in Codecov by Sentry. |
7b10d9a
to
5f031a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodecovAI submitted a new review for 5f031a8
docker-compose.yml
Outdated
@@ -11,7 +11,7 @@ services: | |||
extra_hosts: | |||
- "host.docker.internal:host-gateway" | |||
db: | |||
image: postgres:16.3@sha256:0aafd2ae7e6c391f39fb6b7621632d79f54068faebc726caf469e87bd1d301c0 | |||
image: postgres:16.3@sha256:ca34600b1f2f21c033b4761d88cf763a64201c3af16cffe22d26375c2b9956e3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've updated the Docker image for Postgres here. While this is a straightforward change, please ensure that this new image is compatible with the existing system, as it could contain updates or changes that may need adjustments in the associated codebase. It's a best practice to always pull the new image and test in a controlled environment before promoting it for deployment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodecovAI submitted a new review for 5f031a8
docker-compose.yml
Outdated
@@ -11,7 +11,7 @@ services: | |||
extra_hosts: | |||
- "host.docker.internal:host-gateway" | |||
db: | |||
image: postgres:16.3@sha256:0aafd2ae7e6c391f39fb6b7621632d79f54068faebc726caf469e87bd1d301c0 | |||
image: postgres:16.3@sha256:ca34600b1f2f21c033b4761d88cf763a64201c3af16cffe22d26375c2b9956e3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docker image hash for postgres has been updated. Please, confirm that this new postgres image version doesn't introduce unexpected behavior or breaking changes.
5f031a8
to
7c85672
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodecovAI submitted a new review for 7c85672
docker-compose.yml
Outdated
@@ -11,7 +11,7 @@ services: | |||
extra_hosts: | |||
- "host.docker.internal:host-gateway" | |||
db: | |||
image: postgres:16.3@sha256:0aafd2ae7e6c391f39fb6b7621632d79f54068faebc726caf469e87bd1d301c0 | |||
image: postgres:16.3@sha256:7963e577a0ac17c9718b5f8cbc1b10da3147e2de97c534e3c3ac6e54108957cb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When updating any image, it's advisable to verify any new issues or breaking changes with this updated Postgres image. Also, consider doing a regression testing to check if the application still works as intended after this update. Make sure database schemas didn't change in the new version, or if they did, that these changes are handled appropriately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodecovAI submitted a new review for 7c85672
docker-compose.yml
Outdated
@@ -11,7 +11,7 @@ services: | |||
extra_hosts: | |||
- "host.docker.internal:host-gateway" | |||
db: | |||
image: postgres:16.3@sha256:0aafd2ae7e6c391f39fb6b7621632d79f54068faebc726caf469e87bd1d301c0 | |||
image: postgres:16.3@sha256:7963e577a0ac17c9718b5f8cbc1b10da3147e2de97c534e3c3ac6e54108957cb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Docker image hash for the 'db' service has been changed. It is important to state the reasons behind this change. The new image could have updates or patches that fix vulnerabilities in the previous image, or it might contain new features necessary for the application. Conversely, there could be potential breaking changes introduced with the new image. Please double-check if this hash corresponds to the correct Docker image version and verify if the application runs with no issues with this image.
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sentry-sdk](https://togithub.com/getsentry/sentry-python) ([changelog](https://togithub.com/getsentry/sentry-python/blob/master/CHANGELOG.md)) | `==2.10.0` -> `==2.11.0` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/sentry-sdk/2.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/sentry-sdk/2.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/sentry-sdk/2.10.0/2.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/sentry-sdk/2.10.0/2.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>getsentry/sentry-python (sentry-sdk)</summary> ### [`v2.11.0`](https://togithub.com/getsentry/sentry-python/blob/HEAD/CHANGELOG.md#2110) ##### Various fixes & improvements - Add `disabled_integrations` ([#​3328](https://togithub.com/getsentry/sentry-python/issues/3328)) by [@​sentrivana](https://togithub.com/sentrivana) Disabling individual integrations is now much easier. Instead of disabling all automatically enabled integrations and specifying the ones you want to keep, you can now use the new [`disabled_integrations`](https://docs.sentry.io/platforms/python/configuration/options/#auto-enabling-integrations) config option to provide a list of integrations to disable: ```python import sentry_sdk from sentry_sdk.integrations.flask import FlaskIntegration sentry_sdk.init( ``` ### Do not use the Flask integration even if Flask is installed. disabled_integrations=[ FlaskIntegration(), ], ) ``` - Use operation name as transaction name in Strawberry (#​3294) by @​sentrivana - WSGI integrations respect `SCRIPT_NAME` env variable (#​2622) by @​sarvaSanjay - Make Django DB spans have origin `auto.db.django` (#​3319) by @​antonpirker - Sort breadcrumbs by time before sending (#​3307) by @​antonpirker - Fix `KeyError('sentry-monitor-start-timestamp-s')` (#​3278) by @​Mohsen-Khodabakhshi - Set MongoDB tags directly on span data (#​3290) by @​0Calories - Lower logger level for some messages (#​3305) by @​sentrivana and @​antonpirker - Emit deprecation warnings from `Hub` API (#​3280) by @​szokeasaurusrex - Clarify that `instrumenter` is internal-only (#​3299) by @​szokeasaurusrex - Support Django 5.1 (#​3207) by @​sentrivana - Remove apparently unnecessary `if` (#​3298) by @​szokeasaurusrex - Preliminary support for Python 3.13 (#​3200) by @​sentrivana - Move `sentry_sdk.init` out of `hub.py` (#​3276) by @​szokeasaurusrex - Unhardcode integration list (#​3240) by @​rominf - Allow passing of PostgreSQL port in tests (#​3281) by @​rominf - Add tests for `@ai_track` decorator (#​3325) by @​colin-sentry - Do not include type checking code in coverage report (#​3327) by @​antonpirker - Fix test_installed_modules (#​3309) by @​szokeasaurusrex - Fix typos and grammar in a comment (#​3293) by @​szokeasaurusrex - Fixed failed tests setup (#​3303) by @​antonpirker - Only assert warnings we are interested in (#​3314) by @​szokeasaurusrex ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/rustymotors/server-old). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
7c85672
to
0a87950
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodecovAI submitted a new review for 0a87950
docker-compose.yml
Outdated
@@ -11,7 +11,7 @@ services: | |||
extra_hosts: | |||
- "host.docker.internal:host-gateway" | |||
db: | |||
image: postgres:16.3@sha256:0aafd2ae7e6c391f39fb6b7621632d79f54068faebc726caf469e87bd1d301c0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image for the PostgreSQL service is being updated. Depending on the changes in the new image, this could introduce both new features and bugs. Ensure for thorough testing in your CI/CD pipeline for potential issues that might arise due to the change in PostgreSQL images.
docker-compose.yml
Outdated
@@ -11,7 +11,7 @@ services: | |||
extra_hosts: | |||
- "host.docker.internal:host-gateway" | |||
db: | |||
image: postgres:16.3@sha256:0aafd2ae7e6c391f39fb6b7621632d79f54068faebc726caf469e87bd1d301c0 | |||
image: postgres:16.3@sha256:dba2cc7c4928e44d1157e8b2ab99eaae0ee743837700f17ffbd7a3c544d8da1b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This particular change in SHA signature indicates a different image build, which could come with its own set of issues or improvements. Be sure that this image has been thoroughly vetted against your application's needs before integrating it into your main branch.
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [node](https://nodejs.org) ([source](https://togithub.com/nodejs/node)) | patch | `22.5.0` -> `22.5.1` | --- ### Release Notes <details> <summary>nodejs/node (node)</summary> ### [`v22.5.1`](https://togithub.com/nodejs/node/releases/tag/v22.5.1): 2024-07-19, Version 22.5.1 (Current), @​richardlau [Compare Source](https://togithub.com/nodejs/node/compare/v22.5.0...v22.5.1) ##### Notable Changes This release fixes a regression introduced in Node.js 22.5.0. The problem is known to display the following symptoms: - Crash with `FATAL ERROR: v8::Object::GetCreationContextChecked No creation context available` [#​53902](https://togithub.com/nodejs/node/issues/53902) - npm errors with `npm error Exit handler never called!` [npm/cli#7657](https://togithub.com/npm/cli/issues/7657) - yarn hangs or outputs `Usage Error: Couldn't find the node_modules state file - running an install might help (findPackageLocation)` [yarnpkg/berry#6398](https://togithub.com/yarnpkg/berry/issues/6398) ##### Commits - \[[`e2deeedc6e`](https://togithub.com/nodejs/node/commit/e2deeedc6e)] - ***Revert*** "**fs**: add v8 fast api to closeSync" (Aviv Keller) [#​53904](https://togithub.com/nodejs/node/pull/53904) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/rustymotors/server-old). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pytest](https://togithub.com/pytest-dev/pytest) ([changelog](https://docs.pytest.org/en/stable/changelog.html)) | `==8.2.2` -> `==8.3.1` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/pytest/8.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/pytest/8.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/pytest/8.2.2/8.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/pytest/8.2.2/8.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pytest-dev/pytest (pytest)</summary> ### [`v8.3.1`](https://togithub.com/pytest-dev/pytest/releases/tag/8.3.1) [Compare Source](https://togithub.com/pytest-dev/pytest/compare/8.3.0...8.3.1) # pytest 8.3.1 (2024-07-20) The 8.3.0 release failed to include the change notes and docs for the release. This patch release remedies this. There are no other changes. ### [`v8.3.0`](https://togithub.com/pytest-dev/pytest/compare/8.2.2...8.3.0) [Compare Source](https://togithub.com/pytest-dev/pytest/compare/8.2.2...8.3.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/rustymotors/server-old). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
0a87950
to
8214097
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodecovAI submitted a new review for 8214097
@@ -11,7 +11,7 @@ services: | |||
extra_hosts: | |||
- "host.docker.internal:host-gateway" | |||
db: | |||
image: postgres:16.3@sha256:0aafd2ae7e6c391f39fb6b7621632d79f54068faebc726caf469e87bd1d301c0 | |||
image: postgres:16.3@sha256:d0f363f8366fbc3f52d172c6e76bc27151c3d643b870e1062b4e8bfe65baf609 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please verify whether the new image hash points to a trusted and secure image. This is important to ensure that our application does not face any unnecessary risks.
Quality Gate passedIssues Measures |
Autoclosing SkippedThis PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
This PR contains the following updates:
0aafd2a
->d0f363f
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.