Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the visible
ruvector-core::VectorDB::searchpost-filtering underfill path in current main. Relates to #1310.Root cause
VectorDB::searchretrieved global top-k candidates and then removed disallowed metadata matches without refilling. When the nearest global candidates were from another tenant, the answer could be empty or incomplete despite at least k eligible entries in storage. This matches the failure class documented in the Oct 24 historical comparison; it does not establish byte-for-byte identity with the older npm native package.Change
Explicit boundaries
crates/ruvector-core/src/vector_db.rs, whichcrates/ruvector-node/src/lib.rsdelegates to. It does not update independently shipped npm native binaries, ACORN,FilteredSearchhelper, LlamaIndex PR fix(python): enforce LlamaIndex query restrictions and empty-field filters #1150, or duplicate-ID mutation behavior.Required validation before merge
Then measure filtered p50/p95/p99 at 10K, 100K and 1M vectors, 1%/10% selectivity, exact oracle and multi-tenant validity. Compare published npm binary separately after rebuilding a pinned native addon.
Acceptance: return min(k, eligible_count), unique permitted IDs, correct score/returned-vector alignment, exact ordering for fallback, and no changed unfiltered behavior.