fix(inject_fault): detect QEMU monitor prompt across split recv() chunks , minor bugs too #1267
Open
Anshul1596 wants to merge 1 commit into
Open
fix(inject_fault): detect QEMU monitor prompt across split recv() chunks , minor bugs too #1267Anshul1596 wants to merge 1 commit into
Anshul1596 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes a bug where
send_cmd()only checked the latestrecv()chunk for the(qemu)prompt. If the prompt was split across multiple reads, every command waited for a timeout, slowing down fault injection—especiallyring_flood.Changes
send_cmd()to check the accumulated response for(qemu).ring_floodNMI triggers into a singlesendall().os.urandom(16)infault_nvs_corrupt()for faster random bytes.try/finally.Testing
Tested all fault types against a local QEMU instance. Verified behavior is unchanged, with
ring_floodcompleting noticeably faster.