Fix race condition on shared temp file in batch_predict()#83
Closed
midaa1 wants to merge 6 commits intoruxailab:mainfrom
Closed
Fix race condition on shared temp file in batch_predict()#83midaa1 wants to merge 6 commits intoruxailab:mainfrom
midaa1 wants to merge 6 commits intoruxailab:mainfrom
Conversation
Removed push trigger for main branch and unused steps.
Added push event trigger for CI workflow and included steps for Heroku CLI installation and deployment.
Removed push trigger and Heroku deployment steps from CI workflow.
Use uuid4 to generate unique temp filenames per request, preventing concurrent requests from overwriting each other's CSV data. Also clean up the temp file after prediction to prevent disk space leaks. Fixes ruxailab#82 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
batch_predict()where all concurrent requests wrote to the sametemp_batch_predict.csv, causing incorrect gaze predictions when multiple users hit the endpoint simultaneouslyuuid4to isolate concurrent requestsos.remove()to prevent unbounded disk growthChanges (
app/routes/session.py)import uuidbase_path / "temp_batch_predict.csv"base_path / f"temp_batch_predict_{uuid.uuid4().hex}.csv"os.remove(predict_csv_path)Test plan
batch_predictrequest and verify correct gaze predictions are returnedbatch_predictrequests with differentiris_tracking_dataand verify both return correct, independent resultstemp_batch_predict_*.csvfiles remain incsv/data/after requests completeFixes #82