Skip to content

optimized predict() loop using groupby#85

Open
ChaitanyaChute wants to merge 1 commit intoruxailab:mainfrom
ChaitanyaChute:dev
Open

optimized predict() loop using groupby#85
ChaitanyaChute wants to merge 1 commit intoruxailab:mainfrom
ChaitanyaChute:dev

Conversation

@ChaitanyaChute
Copy link
Copy Markdown

Fixes Issue #74

This PR optimizes the data aggregation step inside predict() by removing row-wise DataFrame iteration and repeated filtering operations. The refactor improves performance by processing grouped data in a single pass instead of repeatedly scanning the DataFrame.

Changes Made

Replaced

  • df_data.iterrows() loop
  • Per-row DataFrame filtering based on (True X, True Y)

Added

  • Single-pass iteration using:
df_data.groupby("True XY")
  • Direct extraction of grouped predictions:
group["Predicted X"].tolist()
group["Predicted Y"].tolist()
  • Reuse of existing precomputed metrics:

    • precision_xy
    • accuracy_xy

Behavior Verification

  • Output dictionary structure remains unchanged
  • Precision and accuracy values remain unchanged
  • Filtering of negative predictions is still respected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant