Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sctk_binary_path variable in Hub5ScoreJob #292

Merged
merged 6 commits into from
Jul 25, 2022
Merged

sctk_binary_path variable in Hub5ScoreJob #292

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fb05f17
Add sctk_binary_path variable to Hub5ScoreJob and add type annotations.
Jul 22, 2022
147fe2b
Reformat.
Jul 22, 2022
0b9b570
Update type annotations
DanEnergetics Jul 22, 2022
a095d6d
Update docstring
DanEnergetics Jul 22, 2022
11c29bc
Update imports.
DanEnergetics Jul 22, 2022
1872a2e
Remove tk.uncached_path.
Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 29 additions & 10 deletions recognition/scoring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,12 +202,27 @@ def calc_wer(self):


class Hub5ScoreJob(Job):
def __init__(self, ref, glm, hyp):
__sis_hash_exclude__ = {"sctk_binary_path": None}

def __init__(
self,
ref: tk.Path,
glm: tk.Path,
hyp: tk.Path,
sctk_binary_path: Optional[tk.Path] = None,
):
DanEnergetics marked this conversation as resolved.
Show resolved Hide resolved
"""
:param ref: reference stm text file
:param glm: text file containing mapping rules for scoring
:param hyp: hypothesis ctm text file
:param sctk_binary_path: set an explicit binary path.
"""
self.set_vis_name("HubScore")

self.glm = glm
self.hyp = hyp
self.ref = ref
self.sctk_binary_path = sctk_binary_path

self.out_report_dir = self.output_path("reports", True)

Expand Down Expand Up @@ -235,29 +250,33 @@ def tasks(self):
yield Task("run", mini_task=True)

def run(self, move_files=True):
hubscr_path = (
os.path.join(gs.SCTK_PATH, "hubscr.pl")
if hasattr(gs, "SCTK_PATH")
else "hubscr.pl"
)
sctk_opt = ["-p", gs.SCTK_PATH] if hasattr(gs, "SCTK_PATH") else []
sctk_path = ""
if self.sctk_binary_path is not None:
sctk_path = self.sctk_binary_path.get_path()
elif hasattr(gs, "SCTK_PATH"):
sctk_path = gs.SCTK_PATH
hubscr_path = os.path.join(
sctk_path, "hubscr.pl"
) # evaluates to just "hubscr.pl" if sctk_path is empty

sctk_opt = ["-p", sctk_path] if sctk_path else []

ref = self.ref
try:
ref = shutil.copy(tk.uncached_path(ref), ".")
ref = shutil.copy(ref.get_path(), ".")
except shutil.SameFileError:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering: why are we copying ref and hyp?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can this be the same file?? "." should be the job work dir, correct? ergo this should not be the same file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we copying ref and hyp?

dunno.

how can this be the same file??

maybe during automatic LM scale optimization?

pass

hyp = self.hyp
try:
hyp = shutil.copy(tk.uncached_path(hyp), ".")
hyp = shutil.copy(hyp.get_path(), ".")
except shutil.SameFileError:
pass

sp.check_call(
[hubscr_path, "-V", "-l", "english", "-h", "hub5"]
+ sctk_opt
+ ["-g", tk.uncached_path(self.glm), "-r", ref, hyp]
+ ["-g", self.glm.get_path(), "-r", ref, hyp]
)

if move_files: # run as real job
Expand Down