This repository was archived by the owner on Oct 19, 2019. It is now read-only.
Don't use shallow clones and update the v8 submodule branch #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shallow setting this is the cause of those two errors: Submodule 'depot_tools' (https://chromium.googlesource.com/chromium/tools/depot_tools.git) registered for path 'depot_tools' Submodule 'v8' (https://github.com/v8/v8.git) registered for path 'v8' Cloning into '/go/src/github.com/ry/v8worker2/depot_tools'... Cloning into '/go/src/github.com/ry/v8worker2/v8'... From https://chromium.googlesource.com/chromium/tools/depot_tools * branch f16fdf3165b8b86d10386d18a6b6075169c10e15 -> FETCH_HEAD error: no such remote ref fe12316ec4b4a101923e395791ca55442e62f4cc Fetched in submodule path 'v8', but it did not contain fe12316ec4b4a101923e395791ca55442e62f4cc. Direct fetching of that commit failed. package github.com/ry/v8worker2: exit status 1 and: depot_tools update failed. Conflict in /go/src/github.com/dlespiau/v8worker2/depot_tools Current theory is that shallow clones aren't enough to find the right commit (for the v8 issue that is), even when specifying the right branch to look for it. So: - Don't use shallow clones - Specify the right branch where to find 6.8 releases, this should help when updating the submodule if one wants to follow the 6.8.x.y releases. Fixes: ry#9
dlespiau
changed the title
dlespiau
changed the title
dlespiau
force-pushed
the
2018-11-02-no-shallow-submodules
branch
from
3374229 to
722c981
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shallow setting this is the cause of those two errors:
and:
Current theory is that shallow clones aren't enough to find the right commit
(for the v8 issue that is), even when specifying the right branch to look for
it.
So:
updating the submodule if one wants to follow the 6.8.x.y releases.
Fixes: #9