Skip to content

Update ImportPagesCSV.module #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update ImportPagesCSV.module #18

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
251f3eb
Update ImportPagesCSV.module
chimmel Aug 26, 2017
95f5054
Update ImportPagesCSV.module
chimmel Aug 26, 2017
171f341
update to upstream (reset)
Oct 4, 2024
1bffe7f
fix for php 8
Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ImportPagesCSV.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ class ImportPagesCSV extends Process implements Module {
*/
public function init() {
parent::init();
ini_set('auto_detect_line_endings', true);
// ini_set('auto_detect_line_endings', true); // depreciated php 8
}

/**
Expand Down Expand Up @@ -225,7 +225,7 @@ class ImportPagesCSV extends Process implements Module {
$f->label = 'Fields delimited by';
$f->addOption(1, 'Commas');
$f->addOption(2, 'Tabs');
$value = $this->sessionGet('csvDelimeter');
$value = (string) $this->sessionGet('csvDelimeter');
if(strlen($value)) {
$f->attr('value', $value === "\t" ? 2 : 1);
} else {
Expand Down Expand Up @@ -512,7 +512,7 @@ class ImportPagesCSV extends Process implements Module {
}

// import post-save data, like files
if($page->id && count($page->get('ImportPagesCSVData'))) {
if($page->id && $page->if('ImportPagesCSVData')) {
foreach($page->get('ImportPagesCSVData') as $name => $value) {
$page->set($name, $value);
}
Expand Down