Added id in buildProfileForm attributes #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After hooking a checkbox field render (to conform to a bootstrap v4.3x checkbox component), I was wondering why it was working for the Register form but not the Profile form.
I then noticed the difference between them in their respective build*Form methods:
$inputfield->attr('name', 'profile_' . $inputfield->attr('name'));vs
$inputfield->attr('id+name', 'register_' . $inputfield->attr('name'));Kindly add the id+ in the Profile buildProfileForm. I'm sure it was just an unintended omission.
Thanks much.