fix: Few bugs in Gossip protocol see description#21
Merged
ryandielhenn merged 3 commits intomainfrom Mar 26, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Currently the gossip protocol reads/writes to
nodewithout acquiring a lock. The server runs the gossip pinger and listener in separate goroutines, so locks are needed to handle race conditions.When a
PingReqwas being being sent by the gossip pinger it was declaring the node that thePingReqwas being sent to as suspect instead of the actual suspect peer.handlePingAckwas sending aPingto the origin node instead of aPingAckif it is not the original pinger.Fixes #16