Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Illegal argument: line must be non-negative #425

Merged

Conversation

sfc-gh-wzhao
Copy link
Contributor


name: Fix Illegal argument: line must be non-negative
about: Fix Illegal argument: line must be non-negative error by ignoring detail whose line attribute is 0


Issue:

Changes:

  • Change the filter in the renferer to ignore detail whose line attribute is 0.

@ryanluker ryanluker added this to the 2.12.0 milestone Sep 17, 2023
@ryanluker ryanluker self-requested a review September 17, 2023 18:15
@ryanluker ryanluker removed their assignment Sep 17, 2023
Copy link
Owner

@ryanluker ryanluker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for the PR!
This will go out with the 2.12.0 release or earlier if we do a smaller minor release sooner.

@ryanluker ryanluker merged commit 0b76767 into ryanluker:master Sep 17, 2023
5 checks passed
@ryanluker ryanluker modified the milestones: 2.12.0, 2.11.1 Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Illegal argument: line must be non-negative when any detail.line is 0
2 participants