Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statusbar reports floor of coverage (resolves #423) #426

Merged
merged 1 commit into from
Sep 17, 2023
Merged

statusbar reports floor of coverage (resolves #423) #426

merged 1 commit into from
Sep 17, 2023

Conversation

guppy0130
Copy link
Contributor

name: statusbar should report Math.floor
about: statusbar should report Math.floor instead of Math.round

Issue:

Changes:

  • in a 200 line file with 1 missed line, statusbar would report 100%
    coverage with Math.round, which is misleading; there is still one
    missed line, so use Math.floor instead (which would report 99%
    coverage)
  • @ryanluker

@guppy0130
statusbar reports floor of coverage (resolves ryanluker#423)
a6c10bc 
* in a 200 line file with 1 missed line, statusbar would report 100%
  coverage with `Math.round`, which is misleading; there is still one
  missed line, so use `Math.floor` instead (which would report 99%
  coverage)
@ryanluker ryanluker added this to the 2.12.0 milestone Sep 17, 2023
@ryanluker ryanluker self-requested a review September 17, 2023 18:14
ryanluker
ryanluker approved these changes Sep 17, 2023
View reviewed changes
Copy link
Owner

@ryanluker ryanluker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guppy0130 Thanks for the PR!
Test and code quality workflows pass, so we are good to merge (this will go out in 2.12.0 unless we do a smaller release earlier depending on the other work in that release).

@ryanluker ryanluker removed their assignment Sep 17, 2023
@ryanluker ryanluker merged commit 23ac71a into ryanluker:master Sep 17, 2023
5 checks passed
@ryanluker ryanluker linked an issue Sep 17, 2023 that may be closed by this pull request
behavior change suggestion/rfc: statusbar should report Math.floor instead of Math.round #423
Closed
@ryanluker ryanluker modified the milestones: 2.12.0, 2.11.1 Nov 12, 2023
@guppy0130 guppy0130 deleted the issue_423_statusbar_reports_floor branch November 13, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanluker ryanluker ryanluker approved these changes

Assignees

@guppy0130 guppy0130

Labels
None yet
Projects
None yet
Milestone
2.11.1
Development

Successfully merging this pull request may close these issues.

behavior change suggestion/rfc: statusbar should report Math.floor instead of Math.round
2 participants
@guppy0130 @ryanluker