Switch to devicons/devicon #1691
Conversation
|
Here a list of which icons will get an update. and which have been dropped in devicons (they have a I marked some with a |
Finii
force-pushed
the
feature/update-devicons
branch
from
0611917 to
71e7ae0
Compare
Finii
force-pushed
the
feature/update-devicons
branch
4 times, most recently
from
a538e34 to
914111f
Compare
|
Here a visual of which icons got dropped upstream (i.e. were in Vorillaz but are not in Devicons/Devicon) marked with blue, and the existing icons updated to Devicons/Devicon.
Dropped icons often are in another set, so the impact is not too bad (e.g. Dropbox, Hackernews, ...) All the vacant codepoints are now used to fill in new icons; so that we have no gaps and still all icons of Devicons v2.16.0: Side by side:
And all:
Some
As I write this I already notice some more problems that I will fix and force-push away soon. Ping to @Snailedlt, discussions if needed can be better done here |
Finii
force-pushed
the
feature/update-devicons
branch
from
914111f to
d0b135a
Compare
|
Great work! |
Finii
force-pushed
the
feature/update-devicons
branch
from
d0b135a to
707dd49
Compare
|
Backport improved fixed icons from PRs in devicons/devicon; force push. |
|
List of dropped icons, their codepoints are reused for new icons.
Not dropped
|
|
This looks amazing, great job! Just few notes:
|
|
Thanks a lot @hasecilu !!
Ah, thank you!
I guess instead of adding it (back) to devicons/devicons I can just keep it, as the other few I already identified as 'must be kept' in the https://github.com/ryanoasis/nerd-fonts/tree/feature/update-devicons/src/glyphs/devicons/vorillaz directory (i.e. some I change the entries in the table above. |
|
Made this small script to create a nice regex and will #!/usr/bin/bash
ICONS=( E700 E701 E705 E706 E707 E708 E70A E713 E715 E71A E71C E720 E723 E72A E72B E72C E72D E72E E72F E730 E731 E732 E733 E734 E735 E741 E74E E74F E754 E756 E75B E75D E75E E75F E760 E761 E762 E765 E766 E76A E76B E76C E76F E770 E771 E773 E779 E77A E77C E785 E786 E788 E789 E78A E78B E78C E78D E78E E78F E790 E791 E792 E793 E794 E795 E796 E797 E799 E79A E79B E79D E79F E7A0 E7A2 E7A3 E7AA E7AC E7B2 E7B7 E7B9 E7BC E7BD E7BE E7BF E7C0 E7C1 E7C2 E7C3)
printf "["
for i in "${ICONS[@]}"; do
printf "\u${i}"
done
printf "]"
for i in "${ICONS[@]}"; do
j=$(echo "${i}" | tr '[:upper:]' '[:lower:]')
printf "\\|%s\\|%s" "${i}" "${j}"
doneAbove: regex.sh
Of course there are false positives etc, but I will collect some more data on which icons are used by default!
|
|
Thanks again for the valuable comment 💚 I guess I will just keep all the icons that I found in some default config. In some moments I think maybe we should not drop any icon and just update and add new ones. |
Finii
force-pushed
the
feature/update-devicons
branch
from
707dd49 to
fca2b21
Compare
|
Force push. |
Finii
force-pushed
the
feature/update-devicons
branch
from
fca2b21 to
28b38cf
Compare
|
As the old Vorillaz icons are unsupported, checked all those (that we keep) and only dropbox needs an update:
Force push. |
[why] Some entries are only needed to adapt the Vorillaz Devicons to the Devicons Devicon. After the mapping file has been adapted we can remove them to clean up for coming updates. Signed-off-by: Fini Jastrow <[email protected]>
[why] The fixed icons have been improved and suggested as fixes upstream. The improvements were missing here. Signed-off-by: Fini Jastrow <[email protected]>
|
So, lets re-start this ;-) Doing patched, noticing:
Fixed |
|
The scaling... Mono is of course all maxed out in the 'cell'.
Left: old icons, right: updated icons Note how extraordinary big JS was before, while Ionic is rather small in comparison to all others. |
Finii
force-pushed
the
feature/update-devicons
branch
from
ef6bf1b to
b7706da
Compare
|
@Finii what do you think on the change I proposed above for nginx glyph? Could be associated to nginx.conf file and would be easier to identify. |
|
Ah it's you @hasecilu (you changed your avatar), yes, will check. Try to get this bloody release out asap ;-) Well, at least working continuously on it. A problem I have with modifying the icons here relative to upstream is of course ... it diverges then. But I will look later and keep you updated 👍 Icon additions is the next thing after this PR, the the fonts, then release 😬 |
|
Script to come up with a changed icons NAME list from a codepoint list in a file: $ for f in `cat ~/dropped`; do
echo "$f $(jq -r "to_entries[] | select(.value.code // \"\"|ascii_upcase == \"$f\")|.key" glyphnames.json)"
done |
Finii
force-pushed
the
feature/update-devicons
branch
from
b7706da to
fa2e6ae
Compare
|
Hmm, they have rounded corners, also the distance from the N to the border of the hexaeder seems different.
... using their original icon thing to come up with an improved icon: |
|
That forcepush was bad, correcting |
[why] Plain icon is missing but would be better than the wordmark icon. [how] Add plain icon, taken from their website. [note] Similar (but slightly different svg) to devicons/devicon#2291 Suggested-by: hasecilu Signed-off-by: Fini Jastrow <[email protected]>
$ ./generate
Program root: /usr
Reading mapping file
Found 496 entries
Unpacking Devicons archive
Mixing Vorillaz Devicons and possible fixes in
Found 1688 svgs
Bad RGB color spec: rgb(0%,0%,0%)
Bad RGB color spec: rgb(0%,0%,0%)
Bad RGB color spec: rgb(0%,0%,0%)
Bad RGB color spec: rgb(0%,0%,0%)
Using fixed svg for angularjs-plain.svg
Using fixed svg for awk-plain.svg
Bad RGB color spec: rgb(0%,0%,0%)
Using fixed svg for bash-plain.svg
Bad RGB color spec: rgb(25.882353%,12.156863%,37.254902%)
Using fixed svg for llvm-plain.svg
Bad RGB color spec: rgb(9.411765%,71.372549%,96.470588%)
Generating devicons.ttf with 496 glyphs
Generating GlyphInfo i_dev.sh
Finished
Signed-off-by: Fini Jastrow <[email protected]>
[why] Some glyphs in the (patched) E7B0-E7CF region seem to be too big. [how] The codepoints in the symbol font are 0x0100 less. These are the "small things" that had a specific scale rule, which is not needed anymore after we dropped these small icons and filled those codepoints with new and bigger icons. Signed-off-by: Fini Jastrow <[email protected]>
Finii
force-pushed
the
feature/update-devicons
branch
from
fa2e6ae to
f1dc799
Compare
|
Updated topmost description, well, except for the new Ready to roll now. |
|
Can you list this is a breaking change in the release notes please. I was affected, and it wasn't immediately clear as to why. |
|
What would you suggest? The codepoints as list, or including the names? I think it can be too bulky and ppl often do not know the codepoints let alone the names. That's why I thought an image would be best, but that can only be placed here. Of course I could add a more explicit warning 🤔 |
As long as the words include "breaking change" and reference the link to this PR somewhere, I think it's fine. Otherwise it's hard to know where to start looking for migration steps. |
|
@XavierChanth Thanks for the feedback! I changed the changelog accordingly: |
Thanks for making the change! |
Notable changes: - 3.1.0 changed family name on some fonts, only Noto affected from our fonts, see details: ryanoasis/nerd-fonts#1434 - 3.3.0 drops and replaces some icons due to switch devicons -devicon see details: ryanoasis/nerd-fonts#1691 Full changelogs available here: - https://github.com/ryanoasis/nerd-fonts/releases/tag/v3.3.0 - https://github.com/ryanoasis/nerd-fonts/releases/tag/v3.2.1 - https://github.com/ryanoasis/nerd-fonts/releases/tag/v3.2.0 - https://github.com/ryanoasis/nerd-fonts/releases/tag/v3.1.1 - https://github.com/ryanoasis/nerd-fonts/releases/tag/v3.1.0 OK: sthen@
Description
Switch from https://github.com/vorillaz/devicons to https://github.com/devicons/devicon to get more relevant developer icons
Fixes: #615
Requirements / Checklist
Issue number where discussion took place: #xxx
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Fixes: #1693
Fixes: #869
Fixes: #952
Fixes: #999
Fixes: #1114
Fixes: #1493
Fixes: #1565
Screenshots (if appropriate or helpful)
UPDATED 13 Nov 2024
List of icons that got dropped (light blue background) and icons that got updated and look 'very' different now (circled pink).
Also note the icon scales are more uniform now.
Old icon set left and part of new icon set right
The complete new set:
List of dropped icons (which are replaced by new icons on the now vacant codepoints)
Amount: 75 icons
No replacement suggestion: 44
Image of dropped icons
E700F00A4E701F069E705F472E708F113E70AF113E713F0BDE715F19EE71AF1D4E71CE720E723F117E72AE72BF19EE72CE72EF0AAEE72FE730E731F2DFE732E733E734E735E741F1AAE74FE754E756E757E75BEF32E75DE75EE75FE760E761E762F03CAE765E766E76BE76CE212E76FE771F36CE773ED32E77AE77CE785E784E788E789F25EE78AE78BE78CE78DE78EE790E792E793E794E796F121E797F045EE799F013E79AEE67E79BF01A7E79DF016AE7A0E7A2F120E7A3EAE9E7ACE7B2E7B7E7B9E7BCE7BDE7BEE7BFE7C0E7C1E7C2E7C3Not dropped
E706F1C0E707F16BE72DE74EE60CE76AE642E770E779F325E786E78FE791F0D2DE795F489E7AAE696