Skip to content

fix: install.sh error 42 when selecting "all" from interactive menu - #2096

Closed
mahdimahdieh wants to merge 1 commit into
ryanoasis:masterfrom
mahdimahdieh:master
Closed

mahdimahdieh wants to merge 1 commit into
ryanoasis:masterfrom
mahdimahdieh:master

Conversation

@mahdimahdieh

Copy link
Copy Markdown

Description

Please explain the changes you made here.

Requirements / Checklist

  • Read the Contributing Guidelines
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.
    Issue number where discussion took place: #xxx
  • If this contains a font/glyph add its origin as background info below (e.g. URL)
  • Verified the license of any newly added font, glyph, or glyph set. License is: xxx

  • I did not use AI/LLM to create this PR, or
  • I disclosed the tool/model below and reviewed its output. I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM. Or
  • I am an AI/LLM agent

What does this Pull Request (PR) do?

fix this issue: #2095

How should this be manually tested?

running ./install.sh install then 73 ("all")

Any background context you can provide?

No

What are the relevant tickets (if any)?

#2095

Screenshots (if appropriate or helpful)

…nteractive menu

When "all" was chosen from the font select menu, the script fell
through to the font-name validation and died with "font all does
not exists in release".
@Finii

Finii commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the PR, but it does not remove the real cause of the problem.

When we run select the user enters a number and that will be 'translated' to the original string of the select call - which is per definition one element of the font list (or "all").

All the lines are leftovers that need to be removed instead. See 539ef18

@Finii Finii closed this Oct 17, 2026
Finii added a commit that referenced this pull request Oct 17, 2026
[why]
After explaining the behavior of `select` in #2096 I noticed that
the `sh_in_array` call for the select answer is completely
unneeded.

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
@Finii

Finii commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator

The select call will fill either one element of font_list or "all" or "" into font_name.
There is no need to check if font_name is a member of font_list

When writing this I noticed the code can be further improved: adbd16a

Screenshot 2026-10-17 at 23 51 20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants