Fixes and Improvements to useHasNewDeploy Hook
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes and Improvements to
useHasNewDeployHookDescription
This PR addresses and fixes several issues in the
useHasNewDeployhook. The following changes have been made to improve the functionality and reliability of the hook:Changes
1. Corrected HTTP Status Code Check
if (response.status > 400)if (response.status >= 400)This change ensures that any response with a status code of 400 or higher will be properly handled as an error.
2. Improved Debug Logging
console.log(...["[Deploy notifications] ", message]);console.log("[Deploy notifications] ", message);The spread operator was unnecessary in this context and has been removed for clearer and more efficient logging.
3. Corrected Interval Logic
let loopInterval = interval < 3_000 ? interval : 3_000;let loopInterval = interval > 3_000 ? interval : 3_000;This update ensures that the interval logic correctly enforces a minimum interval of 3,000 milliseconds.