Develop dual fix customer by haiwentelink · Pull Request #358 · s07641069/connectedhomeip

haiwentelink · 2024-12-23T08:29:57Z

!!!!!!!!!! Please delete the instructions below and replace with PR description

If you have an issue number, please use a syntax of
Fixes #12345 and a brief change description

If you do not have an issue number, please have a good description of
the problem and the fix. Help the reviewer understand what to expect.

Make sure you delete these instructions (to prove you have read them).

!!!!!!!!!! Instructions end

damien0x0023

It's generally okay on code style.
Please add some content into this PR description.
Regarding the comments, you may refine them if have spare time.

damien0x0023 · 2025-01-02T11:00:42Z

    default n

+config CUSTOMER_MODE
+    bool "control the demo code"


Suggest to replace it with "Enable/Disable Customer Mode"

@damien0x0023 should not use enable , so change to control , or CI wil fail which will check enable words in descriptor.

damien0x0023 · 2025-01-02T11:06:11Z

                                       uint8_t * value)
 {
+#if CONFIG_CUSTOMER_MODE
+    /* user mode , add the customer code here for cb*/


customer mode

will change

damien0x0023 · 2025-01-02T11:10:36Z

+#elif CONFIG_SOC_RISCV_TELINK_TL321X
+#define ZB_NVS_PARTITION slot1_partition
+#define ZB_NVS_PARTITION_DEVICE FIXED_PARTITION_DEVICE(ZB_NVS_PARTITION)
+#define ZB_NVS_START_ADR FIXED_PARTITION_OFFSET(ZB_NVS_PARTITION)


If possible, we may move the line 49&50 after the condition clauses so that we can remove the line 54&55.

will change

damien0x0023 · 2025-01-02T11:12:05Z

 {
    // Erase the user parameters partition to reset mode settings
    flash_erase(flash_para_dev, USER_PARTITION_OFFSET, USER_PARTITION_SIZE);
+    // Need to erase zb nvs part in factory mode


"Erase ZigBee NVS data during factory reset"

will change

damien0x0023 · 2025-01-02T11:15:43Z

    if (user_para.val == USER_ZB_SW_VAL)
    {
        sBoot_zb = 1;
+        /* if switch from zb , need to get all the cluster info from zb */


If switching from ZigBee mode, get all existing clusters information.

will change

damien0x0023 · 2025-01-02T11:23:33Z

     * a given timeframe.
     */
    flash_read(flash_para_dev, USER_PARTITION_OFFSET, &user_para, sizeof(user_para));
+    /* Boot from Zigbee , need to clean the user parameters sector first and set a flag */


If booting from Zigbee mode, set a flag and clean deprecated parameter sectors.

will change

damien0x0023 · 2025-01-02T11:26:14Z


    PrintFirmwareInfo();
+#if CONFIG_CUSTOMER_MODE



It would be better to add some description here to remind developers, e.g. "/* Leave empty condition clause for development on customers' boards */"

will change

damien0x0023 · 2025-01-02T11:29:14Z

    case DeviceEventType::kCommissioningComplete: {
        uint8_t val = USER_MATTER_PAIR_VAL;
+#if CONFIG_CUSTOMER_MODE
+        /* need to add here to update the cluster information , only in the zb switch and touchlink is paired*/


Update all cluster information, only if switching from ZigBee mode and the touchlink is paired.

will change

damien0x0023 · 2025-01-02T11:30:12Z

+        if (user_para.val == USER_ZB_SW_VAL && user_para.on_net)
+        {
+            Protocols::InteractionModel::Status status;
+            /* Switch from the touch link, need to restore previous values */


If switching from the touch link, restore the previous light status values

will change

- clean the boot flag in init part . - add the kDnsstimer to protect from init to dnss . - add special proc for ikea. - add the user-para proc in matter. - add 2m flash for buteo ,and 4m for b92. - update CI for b92 and tl3218x . - fix the switch logic part . Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>

haiwentelink requested a review from s07641069 as a code owner December 23, 2024 08:29

github-actions Bot added examples platform config telink github workflows labels Dec 23, 2024

fengtai-telink force-pushed the develop_dual_fix_customer branch from 3e37ea6 to e0255ce Compare December 24, 2024 02:39

haiwentelink force-pushed the develop_dual_fix_customer branch 3 times, most recently from 1ac3915 to 1f690c8 Compare December 25, 2024 03:20

haiwentelink closed this Dec 30, 2024

haiwentelink force-pushed the develop_dual_fix_customer branch from 1f690c8 to e7b9e81 Compare December 30, 2024 06:53

haiwentelink reopened this Dec 30, 2024

haiwentelink force-pushed the develop_dual_fix_customer branch 4 times, most recently from 0d91545 to 53353ae Compare December 30, 2024 09:19

s07641069 approved these changes Dec 30, 2024

View reviewed changes

haiwentelink force-pushed the develop_dual_fix_customer branch 3 times, most recently from f8878a1 to 8240c09 Compare January 2, 2025 02:34

haiwentelink requested a review from damien0x0023 January 2, 2025 02:50

haiwentelink force-pushed the develop_dual_fix_customer branch from 8240c09 to 2975a9d Compare January 2, 2025 04:07

damien0x0023 approved these changes Jan 2, 2025

View reviewed changes

damien0x0023 requested a review from andy-liu-telink January 2, 2025 11:33

haiwentelink force-pushed the develop_dual_fix_customer branch from 2975a9d to 55d3a7b Compare January 2, 2025 11:48

haiwentelink merged commit 0bfa808 into develop_dual Jan 3, 2025

haiwentelink deleted the develop_dual_fix_customer branch January 3, 2025 01:29

Conversation

haiwentelink commented Dec 23, 2024

Uh oh!

damien0x0023 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

damien0x0023 left a comment •

edited

Loading